RFR: 8282279: Interpret case-insensitive string locale independently

2022-02-22 Thread Xue-Lei Andrew Fan
The String.toUpperCase() or String.toLowerCase() method is locale sensitive, and may produce unexpected results if used for strings that are intended to be interpreted locale independently. The use of the two methods had been cleaned before, but there are a few new introduced laterly. See http

RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-02-22 Thread Hai-May Chao
This fixes jarsigner to enforce checking against algorithm constraint properties so when the signature algorithms parameters use disabled or legacy algorithms, it will emit warnings accordingly. If the algorithm used in parameters is disabled, jarsigner treats the jar as unsigned. -

Re: RFR: 8280409: JarFile::getInputStream can fail with NPE accessing ze.getName() [v8]

2022-02-22 Thread Lance Andersen
> Hi all, > > Please review the attached patch to address > > - That JarFile::getInputStream did not check for a null ZipEntry passed as a > parameter > - Have Zip/JarFile::getInputStream throw a ZipException in the event that an > unexpected exception occurs > > Mach5 tiers1-3 runs are clean

Re: RFR: 8280409: JarFile::getInputStream can fail with NPE accessing ze.getName() [v4]

2022-02-22 Thread Lance Andersen
On Sat, 19 Feb 2022 10:59:56 GMT, Alan Bateman wrote: > > Ok, thank you for the feedback. I just pushed a change with additional > > comments on the jar creation which hopefully will address your input above. > > It's a bit better but I think it needs a clear step-by-step instructions in a > c

Withdrawn: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-02-22 Thread Hai-May Chao
On Tue, 22 Feb 2022 20:18:19 GMT, Hai-May Chao wrote: > This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters i

RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-02-22 Thread Hai-May Chao
This fixes jarsigner to enforce checking against algorithm constraint properties so when the signature algorithms parameters use disabled or legacy algorithms, it will emit warnings accordingly. If the algorithm used in parameters is disabled, jarsigner treats the jar as unsigned. -

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string liter

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:35:09 GMT, Magnus Ihse Bursie wrote: >> Done > > Did you forget to push the fix? Push works better when connected... this time it's pushed for real. - PR: https://git.openjdk.java.net/jdk/pull/7565

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 14:13:43 GMT, Daniel Jeliński wrote: >> make/autoconf/flags-cflags.m4 line 136: >> >>> 134: CFLAGS_WARNINGS_ARE_ERRORS="-WX" >>> 135: >>> 136: WARNINGS_ENABLE_ALL="-W3 -Zc:strictStrings" >> >> This is not strictly a flag to enable warnings. I'd recommend you mov

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
> Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal to a non-const pointer > a compile-time error. > > This t

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 11:33:52 GMT, Magnus Ihse Bursie wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string li

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread David Holmes
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread Magnus Ihse Bursie
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal

Integrated: 8282220: contentType should not be a PKCS7's member

2022-02-22 Thread John Jiang
On Tue, 22 Feb 2022 06:03:33 GMT, John Jiang wrote: > `contentType` should be a local variable because it is only used in method > `parse(DerInputStream derin, boolean oldStyle)`. > This change also improves some exception catch blocks. This pull request has now been integrated. Changeset: b95