Re: RFR: 8281234: The -protected option is not always checked in keytool and jarsigner [v2]

2022-02-24 Thread Hai-May Chao
On Fri, 4 Feb 2022 01:19:51 GMT, Weijun Wang wrote: >> The option means there is no need to provide a password when loading a >> keystore. In some places in jarsigner and keytool, even with the option >> specified, password is still prompted for or warnings are still shown. > > Weijun Wang has

Integrated: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-24 Thread Daniel Jeliński
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-24 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string liter

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-24 Thread Weijun Wang
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string liter

Integrated: 8282316: Operation before String case conversion

2022-02-24 Thread Xue-Lei Andrew Fan
On Wed, 23 Feb 2022 19:25:10 GMT, Xue-Lei Andrew Fan wrote: > In the SignatureUtil implementation, the checkName() requires > case-insensitive input for "OID". However, the method is called before the > case conversion, for example: > > sigName = checkName(sigName).toUpperCase(Lo