Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Xue-Lei Andrew Fan
On Mon, 28 Feb 2022 19:44:19 GMT, Jamil Nimeh wrote: >> src/java.base/share/classes/sun/security/ssl/CompressionAlgorithm.java line >> 49: >> >>> 47: } >>> 48: >>> 49: static CompressionAlgorithm nameOf(String name) { >> >> Shouldn't this be valueOf? We're not consistent in the

Re: [Internet]Re: JEP Review Request: TLS Certificate Compression

2022-02-28 Thread xueleifan(XueleiFan)
Hi, It may be better to have more detail here, rather than refer you to the draft JEP. The first question maybe, if TLS Certificate Compression is something we want it in OpenJDK? The TLS Certificate Compression standard was described in RFC 8879, and has been enabled in browser Chrome and

Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Jamil Nimeh
On Mon, 28 Feb 2022 19:41:59 GMT, Jamil Nimeh wrote: >> Hi, >> >> Please review the implementation of RFC 8879, TLS Certificate Compression, >> in JDK. The TLS Certificate Compression standard is an essential part for >> QUIC connections and performance improvement for TLS connections. More

Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Jamil Nimeh
On Wed, 23 Feb 2022 20:15:24 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > Please review the implementation of RFC 8879, TLS Certificate Compression, in > JDK. The TLS Certificate Compression standard is an essential part for QUIC > connections and performance improvement for TLS connections.

Re: JEP Review Request: TLS Certificate Compression

2022-02-28 Thread xueleifan(XueleiFan)
Hi, Could I have this JEP reviewed? One or more qualified Committers review is required to move it forward. Here is the PR if you want to have a further look at the implementation and test: https://github.com/openjdk/jdk/pull/7599 Thanks, Xuelei On Feb 15, 2022, at 9:30 PM,

Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v9]

2022-02-28 Thread Weijun Wang
On Fri, 18 Feb 2022 20:05:46 GMT, Weijun Wang wrote: >> The enhancement adds two extra items in the `getSubjectAlternativeNames()` >> output for an OtherName. >> >> It also fix several errors: >> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` >> without the tag

Integrated: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName

2022-02-28 Thread Weijun Wang
On Thu, 20 Jan 2022 19:42:22 GMT, Weijun Wang wrote: > The enhancement adds two extra items in the `getSubjectAlternativeNames()` > output for an OtherName. > > It also fix several errors: > 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` > without the tag and