Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Naoto Sato
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Chris Plummer
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata

Integrated: 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion

2022-03-10 Thread John Jiang
On Thu, 10 Mar 2022 06:52:14 GMT, John Jiang wrote: > In class sun.security.ssl.ProtocolVersion, the exception message for > unsupported protocol needs a space. > > ProtocolVersion pv = ProtocolVersion.nameOf(pn); > if (pv == null) { > throw new IllegalArgumentException( >

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Alisen Chung
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: moved CurrencyNames changes to jdk.localedata - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new:

Re: RFR: 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion [v2]

2022-03-10 Thread Sean Mullan
On Thu, 10 Mar 2022 14:38:27 GMT, John Jiang wrote: >> In class sun.security.ssl.ProtocolVersion, the exception message for >> unsupported protocol needs a space. >> >> ProtocolVersion pv = ProtocolVersion.nameOf(pn); >> if (pv == null) { >> throw new IllegalArgumentException( >>

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Daniel Fuchs
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote: > IIRC, localized resource files should have the same copyright year as the > base English one. That's what I was told by the l10n engineer when I had the > same comment. Thanks Naoto! I have no objection then. - PR:

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Naoto Sato
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 IIRC, localized resource files should have the same copyright year as the base English one. That's what I was told by the l10n engineer when I had the same comment. - PR:

Re: RFR: 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion [v2]

2022-03-10 Thread John Jiang
> In class sun.security.ssl.ProtocolVersion, the exception message for > unsupported protocol needs a space. > > ProtocolVersion pv = ProtocolVersion.nameOf(pn); > if (pv == null) { > throw new IllegalArgumentException( >"Unsupported protocol" + pn); > } John Jiang has updated

Re: RFR: 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion

2022-03-10 Thread Sean Mullan
On Thu, 10 Mar 2022 06:52:14 GMT, John Jiang wrote: > In class sun.security.ssl.ProtocolVersion, the exception message for > unsupported protocol needs a space. > > ProtocolVersion pv = ProtocolVersion.nameOf(pn); > if (pv == null) { > throw new IllegalArgumentException( >

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Daniel Fuchs
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For simple webserver resource files - should the copyright year be 2022? - PR: https://git.openjdk.java.net/jdk/pull/7765

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v3]

2022-03-10 Thread Сергей Цыпанов
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with > smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when > called with vararg of size 0, 1, 2. > > In general replacement of `Arrays.asList()` with `List.of()` is dubious as > the latter is

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]

2022-03-10 Thread Сергей Цыпанов
On Wed, 9 Mar 2022 16:09:01 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282662: Revert dubious changes > > src/java.base/share/classes/java/lang/invoke/MethodType.java line 910: > >> 908: