Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]

2022-03-23 Thread Bradford Wetmore
On Wed, 23 Mar 2022 18:09:46 GMT, Xue-Lei Andrew Fan wrote: >> Bradford Wetmore has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor

2022-03-23 Thread Weijun Wang
On Thu, 24 Mar 2022 00:52:28 GMT, Valerie Peng wrote: >> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line >> 114: >> >>> 112: * recommended to explicitly specify all desired parameter >>> 113: * values with >>> 114: * {@link

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor

2022-03-23 Thread Valerie Peng
On Wed, 23 Mar 2022 02:51:08 GMT, Weijun Wang wrote: >> Can someone help review this update to the PSSParameterSpec class regarding >> the constructor with int argument and the DEFAULT static field? Just added >> @Deprecate javadoc tag and caution about their usage as suggested in the bug >>

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor

2022-03-23 Thread Valerie Peng
On Wed, 23 Mar 2022 02:46:20 GMT, Weijun Wang wrote: >> Can someone help review this update to the PSSParameterSpec class regarding >> the constructor with int argument and the DEFAULT static field? Just added >> @Deprecate javadoc tag and caution about their usage as suggested in the bug >>

Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor

2022-03-23 Thread Valerie Peng
On Wed, 23 Mar 2022 02:37:18 GMT, Weijun Wang wrote: >> Can someone help review this update to the PSSParameterSpec class regarding >> the constructor with int argument and the DEFAULT static field? Just added >> @Deprecate javadoc tag and caution about their usage as suggested in the bug >>

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v8]

2022-03-23 Thread Valerie Peng
> It's been several years since we increased the default key sizes. Before > shifting to PQC, NSA replaced its Suite B cryptography recommendations with > the Commercial National Security Algorithm Suite which suggests: > > - SHA-384 for secure hashing > - AES-256 for symmetric encryption > -

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v7]

2022-03-23 Thread Valerie Peng
On Wed, 23 Mar 2022 21:51:51 GMT, Xue-Lei Andrew Fan wrote: >> My very first prototype is to implement the AES keysize calculation as you >> commented, i.e. in the static block and use an int for DEF_AES_KEY_SIZE. >> However, it is later discovered through testing that this leads to deadlocks

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v7]

2022-03-23 Thread Xue-Lei Andrew Fan
On Wed, 23 Mar 2022 20:45:22 GMT, Valerie Peng wrote: >> src/java.base/share/classes/sun/security/util/SecurityProviderConstants.java >> line 129: >> >>> 127: return currVal; >>> 128: } >>> 129: >> >> I'm not very sure of this method. Is it performance friendly if making the >>

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v7]

2022-03-23 Thread Valerie Peng
On Wed, 23 Mar 2022 04:46:48 GMT, Xue-Lei Andrew Fan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor code refactoring > > src/java.base/share/classes/sun/security/util/SecurityProviderConstants.java > line

Re: RFR: 8283426: Fix 'exeption' typo [v4]

2022-03-23 Thread Andrey Turbanov
> Fix repeated typo `exeption` Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8283426: Fix 'exeption' typo Co-authored-by: Alexey Ivanov <70774172+aivanov-...@users.noreply.github.com> - Changes: - all:

Integrated: 8163327: Remove 3DES from the default enabled cipher suites list

2022-03-23 Thread Sean Mullan
On Mon, 21 Mar 2022 19:40:07 GMT, Sean Mullan wrote: > This fix removes obsolete and deprecated 3DES cipher suites from the default > enabled cipher suites list of the SunJSSE provider implementation. > > Note that 3DES suites are already disabled by default via the >

Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]

2022-03-23 Thread Xue-Lei Andrew Fan
On Wed, 23 Mar 2022 17:01:12 GMT, Bradford Wetmore wrote: >> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal >> internal_error (80) and invalidate existing sessions (either completed or >> under construction) as described in (RFC 4346/TLSv1.1+) if a connection was >>

Re: SSLEngine.unwrap on read-only input ByteBuffer

2022-03-23 Thread Bradford Wetmore
Offhand, sounds like a bug to me. I've filed: https://bugs.openjdk.java.net/browse/JDK-8283577 to track. It's possible an optimization might have been done using an in-place en/decryption, but it should work. By chance, do you have a simple reproducer handy? If not, we should be able to

Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]

2022-03-23 Thread Bradford Wetmore
> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal > internal_error (80) and invalidate existing sessions (either completed or > under construction) as described in (RFC 4346/TLSv1.1+) if a connection was > closed without receiving a close_notify alert from the peer. >

SSLEngine.unwrap on read-only input ByteBuffer

2022-03-23 Thread Chris Vest
Hi, In Netty we've been trying to design some safer APIs, and attempted to make more use of read-only ByteBuffers. We discovered that SSLEngine.unwrap does not like read-only input buffers, even though the input buffers should in theory only be read from. We obviously make sure that the output

Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368

2022-03-23 Thread Bradford Wetmore
On Wed, 23 Mar 2022 15:10:21 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 799: >> >>> 797: } finally { >>> 798: conContext.closeInbound(); >>> 799: engineLock.unlock(); >> >> I see that

Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368

2022-03-23 Thread Xue-Lei Andrew Fan
On Wed, 23 Mar 2022 11:34:33 GMT, Daniel Fuchs wrote: >> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal >> internal_error (80) and invalidate existing sessions (either completed or >> under construction) as described in (RFC 4346/TLSv1.1+) if a connection was >>

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-23 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull

Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368

2022-03-23 Thread Daniel Fuchs
On Sat, 12 Mar 2022 00:55:07 GMT, Bradford Wetmore wrote: > JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal > internal_error (80) and invalidate existing sessions (either completed or > under construction) as described in (RFC 4346/TLSv1.1+) if a connection was >

Re: RFR: 8283426: Fix 'exeption' typo [v3]

2022-03-23 Thread Alexey Ivanov
On Wed, 23 Mar 2022 07:31:23 GMT, Andrey Turbanov wrote: >> Fix repeated typo `exeption` > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8283426: Fix 'exeption' typo > fix more typos, found by Sean Coffey Marked as

Re: RFR: 8283426: Fix 'exeption' typo [v3]

2022-03-23 Thread Andrey Turbanov
> Fix repeated typo `exeption` Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8283426: Fix 'exeption' typo fix more typos, found by Sean Coffey - Changes: - all: https://git.openjdk.java.net/jdk/pull/7879/files

Integrated: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

2022-03-23 Thread Sibabrata Sahoo
On Wed, 9 Mar 2022 15:03:31 GMT, Sibabrata Sahoo wrote: > Domain value for system property jdk.https.negotiate.cbt is case-insensitive > now. Included Test has been updated to address the change. This pull request has now been integrated. Changeset: 86015e15 Author:Sibabrata Sahoo URL: