Re: RFR: JDK-8286348: incorrect use of `@serial`

2022-05-06 Thread Iris Clark
On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote: > Please review a fix to remove incorrect use of the `@serial` tag from the doc > comments for methods such as `readObject` and `readResolve`. The tag has no > effect in this position other than to trigger warnings from the standard >

RFR: JDK-8286348: incorrect use of `@serial`

2022-05-06 Thread Jonathan Gibbons
Please review a fix to remove incorrect use of the `@serial` tag from the doc comments for methods such as `readObject` and `readResolve`. The tag has no effect in this position other than to trigger warnings from the standard doclet when running javadoc. There is no change to the generated

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Bradford Wetmore
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote: > JDK-6725221 Standardize obtaining boolean properties with defaults Sorry for the confusion. The original intent of this bug 14 years ago was to standardize the seclibs code where simple getProperty calls were needed in the context of an

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Phil Race
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote: > JDK-6725221 Standardize obtaining boolean properties with defaults The xtoolkit change is fine. I've not looked at anything else You'll clearly need multiple reviewers for this one. - Marked as reviewed by prr (Reviewer). PR:

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Alan Bateman
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote: > JDK-6725221 Standardize obtaining boolean properties with defaults src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777: > 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) { > 776:

RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Mark Powers
JDK-6725221 Standardize obtaining boolean properties with defaults - Commit messages: - Merge - first iteration Changes: https://git.openjdk.java.net/jdk/pull/8559/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8559=00 Issue:

Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]

2022-05-06 Thread Mark Powers
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split

Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v6]

2022-05-06 Thread Mark Powers
> https://bugs.openjdk.java.net/browse/JDK-8284688 > > [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the > umbrella bug for this bug. The changes were too large for a single code > review, so it was decided to split into smaller chunks. This is one such > chunk: > >

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v2]

2022-05-06 Thread Jaikiran Pai
On Fri, 6 May 2022 09:38:38 GMT, Daniel Fuchs wrote: >> Hi, please find here a patch that solves a rare intermittent test failure >> observed in the test `java/net/httpclient/ExecutorShutdown.java` >> >> A race condition coupled with some too eager synchronization was causing a >> deadlock

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v2]

2022-05-06 Thread Jaikiran Pai
On Fri, 6 May 2022 09:14:53 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java >> line 1039: >> >>> 1037: e.abort(selectorClosedException()); >>> 1038: } else { >>> 1039: selector.wakeup(); >> >>

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v2]

2022-05-06 Thread Daniel Fuchs
On Fri, 6 May 2022 05:16:15 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a comment to ReferenceTracker.java as suggested in the review > >

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v2]

2022-05-06 Thread Daniel Fuchs
> Hi, please find here a patch that solves a rare intermittent test failure > observed in the test `java/net/httpclient/ExecutorShutdown.java` > > A race condition coupled with some too eager synchronization was causing a > deadlock between an Http2Connection close, a thread trying to shutdown

Re: RFR: 8286194: ExecutorShutdown test fails intermittently

2022-05-06 Thread Daniel Fuchs
On Fri, 6 May 2022 04:57:00 GMT, Jaikiran Pai wrote: >> Hi, please find here a patch that solves a rare intermittent test failure >> observed in the test `java/net/httpclient/ExecutorShutdown.java` >> >> A race condition coupled with some too eager synchronization was causing a >> deadlock

Re: RFR: 8286194: ExecutorShutdown test fails intermittently

2022-05-06 Thread Daniel Fuchs
On Fri, 6 May 2022 04:49:53 GMT, Jaikiran Pai wrote: >> Hi, please find here a patch that solves a rare intermittent test failure >> observed in the test `java/net/httpclient/ExecutorShutdown.java` >> >> A race condition coupled with some too eager synchronization was causing a >> deadlock