Re: RFR: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5 [v3]

2022-05-23 Thread Weijun Wang
On Mon, 23 May 2022 21:44:39 GMT, Valerie Peng wrote: >> Need to update the 3 header files due to expiring business approval for 3rd >> party. >> >> The header files contain tabs which jcheck disallows, so I have to replace >> them with spaces. >> >> Thanks, >> Valerie > > Valerie Peng has

Re: RFR: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5 [v3]

2022-05-23 Thread Valerie Peng
> Need to update the 3 header files due to expiring business approval for 3rd > party. > > The header files contain tabs which jcheck disallows, so I have to replace > them with spaces. > > Thanks, > Valerie Valerie Peng has updated the pull request incrementally with one additional commit

Re: RFR: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5 [v2]

2022-05-23 Thread Valerie Peng
> Need to update the 3 header files due to expiring business approval for 3rd > party. > > The header files contain tabs which jcheck disallows, so I have to replace > them with spaces. > > Thanks, > Valerie Valerie Peng has updated the pull request incrementally with one additional commit

RFR: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5

2022-05-23 Thread Valerie Peng
Need to update the 3 header files due to expiring business approval for 3rd party. The header files contain tabs which jcheck disallows, so I have to replace them with spaces. Thanks, Valerie - Commit messages: - Replaced tab with spaces in order to pass jcheck. - 8286211:

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v2]

2022-05-23 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The

Integrated: 8287109: Distrust.java failed with CertificateExpiredException

2022-05-23 Thread Rajan Halade
On Mon, 23 May 2022 20:14:37 GMT, Rajan Halade wrote: > Incorporated patch from my @seanjmullan and removed expired root chains. This pull request has now been integrated. Changeset: 5b7d066c Author:Rajan Halade URL:

RFR: 8287109: Distrust.java failed with CertificateExpiredException

2022-05-23 Thread Rajan Halade
Incorporated patch from my @seanjmullan and removed expired root chains. - Commit messages: - Reformat code - Update ProblemList - 8287109: Distrust.java failed with CertificateExpiredException Changes: https://git.openjdk.java.net/jdk/pull/8856/files Webrev:

Re: RFR: 8287109: Distrust.java failed with CertificateExpiredException

2022-05-23 Thread Sean Mullan
On Mon, 23 May 2022 20:14:37 GMT, Rajan Halade wrote: > Incorporated patch from my @seanjmullan and removed expired root chains. LGTM although someone else should probably have a look over this since I contributed the fix. test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v3]

2022-05-23 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: Update copyright to 2022

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults [v2]

2022-05-23 Thread Roger Riggs
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote: >> JDK-6725221 Standardize obtaining boolean properties with defaults > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Alan and Jamil comments

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults [v2]

2022-05-23 Thread Mark Powers
On Mon, 23 May 2022 18:34:41 GMT, Roger Riggs wrote: >> You are right. The old way maps the null string to true, and the new way >> maps it to false. I did not notice that. At this point, I see no value in >> making the "true".equals and "false".equals changes. Too much can break. >> I'll

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults [v2]

2022-05-23 Thread Mark Powers
> JDK-6725221 Standardize obtaining boolean properties with defaults Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Alan and Jamil comments - Merge - reverse true.equals and false.equals changes -

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-23 Thread Roger Riggs
On Tue, 10 May 2022 19:24:24 GMT, Mark Powers wrote: >> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777: >> >>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) { >>> 776: printStackWhenAccessFails = GetBooleanAction. >>> 777:

Integrated: 8286908: ECDSA signature should not return parameters

2022-05-23 Thread Weijun Wang
On Tue, 17 May 2022 19:56:22 GMT, Weijun Wang wrote: > Let ECDSA's `engineGetParameters()` always return null. At the same time, > remove the remembered `sigParams` field. One behavior change is that after > calling `setParameter()`, one can call `init()` again with a key using > different

Integrated: 8286715: Generalize MemorySegment::ofBuffer

2022-05-23 Thread Maurizio Cimadamore
On Fri, 13 May 2022 12:33:10 GMT, Maurizio Cimadamore wrote: > This patch makes MemorySegment::ofBuffer more general, by allowing clients to > pass *any* `Buffer` instance, not just `ByteBuffer`. > This allows us to match expressiveness of JNI API, where JNI clients can > obtain the address