Re: PATCH: possible bug in OCSP check

2013-05-28 Thread Christophe Ravel
ew advise I have made a little patchagainst current openjdk-8 that just considers both of them (OCSPResponseclass receives both certs and this way can check the three cases).Thanks in advance! -- Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162Oracle Java SQE - Security42

Re: RFR: 8012261: update policytool to support java.net.HttpURLPermission

2013-05-17 Thread Christophe Ravel
    8010464: Evolve java networking same origin policy     http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 Noreg-trivial. Thanks Max -- Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162Oracle Java SQE - Security4220 Network Circle, Office 2140, Santa Clara, CA

Re: Code review request: 8011867 and 8011745, pkcs data types

2013-04-10 Thread Christophe Ravel
et/~weijun/8011745/webrev.00/ Could you add a regression test for this fix ? 8011867: Accept unknown PKCS #9 attributes    http://cr.openjdk.java.net/~weijun/8011867/webrev.00/ SQE: ok Thanks Max Regards, Christophe. -- Christophe Ravel | Principal Member of Techn

Re: Code review request, 7200295 CertificateRequest message is wrapping when using large numbers of Certs

2012-09-27 Thread Christophe Ravel
Thanks. Christophe. On Sep 26, 2012, at 8:13 PM, Xuelei Fan wrote: > A new regression test was added. > > http://cr.openjdk.java.net./~xuelei/7200295/webrev.01/ > > Thanks, > Xuelei > > On 9/26/2012 4:53 AM, Christophe Ravel wrote: >> Hi Andrew, >> >

Re: Code review request, 7200295 CertificateRequest message is wrapping when using large numbers of Certs

2012-09-25 Thread Christophe Ravel
~xuelei/7200295/webrev.00/ >>> >>> The cause of the bug is that for 8, 16, 24 bits length-variable fields, >>> before put the bytes into the fields, we do not check that the length of >>> the bytes is less than the capabilities of the field. >>> >>> Thanks, >>> Xuelei >>> > Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162 Oracle Java SQE - Security 4220 Network Circle, B160A, Santa Clara, CA

Re: code review request for 6880559: Enable PKCS11 64-bit windows builds

2012-07-12 Thread Christophe Ravel
tp://cr.openjdk.java.net/~vinnie/6880559/webrev.00/ > > It includes NSS 3.13.1 libraries for Windows 32-bit and 64-bit in the > PKCS11 testsuite. PKCS11 tests on Solaris and Linux continue to use > NSS from the operating system. > > Thanks. Christophe Ravel | Principal Member of Tec