On Mon, 4 Apr 2022 14:57:30 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote:
> Fix repeated typo `exeption`
Looks good.
Thanks for cleaning this up.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7879
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote:
> Please review this PR that enables
> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
> compiler flag, which makes assigning a string literal
On Fri, 11 Feb 2022 08:54:51 GMT, Leo Korinth wrote:
>> Remove unused imports under test/lib and jtreg/gc. They create lots of
>> warnings if editing using an IDE. Tests in hotspot_gc passed.
>
> Leo Korinth has updated the pull request incrementally with one additional
> commit since the last
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote:
> Remove unused imports under test/lib and jtreg/gc. They create lots of
> warnings if editing using an IDE. Tests in hotspot_gc passed.
Forgot to mention copyright years need updating before integrating! Thanks.
-
PR: https://g
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote:
> Remove unused imports under test/lib and jtreg/gc. They create lots of
> warnings if editing using an IDE. Tests in hotspot_gc passed.
Looks fine. The proof of these changes is in compiling the files - how did you
test the non-gc-test chan
On Sun, 19 Dec 2021 07:37:19 GMT, Alan Bateman wrote:
>> Enable the security manager in rmiregistry's launcher arguments.
>
> As things stand, `rmiregsitry -J-Djava.security.manager` and `rmiregistry
> -J-Djava.security.manager=allow` are equivalent because rmiregistry sets the
> default SM. So
.html
(or https://github.com/openjdk/jdk/pull/6191#pullrequestreview-79465)
[^2]:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html
_Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
[core-libs-dev](mailto:core-libs
On Sat, 16 Oct 2021 11:11:59 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-419 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 21 Sep 2021 17:52:31 GMT, Brian Burkhalter wrote:
>> We can either revert this part of the change or rephrase it. Mind you,
>> rephrasing might prove tricky because of non-local changes it might
>> introduce. There's one more occurrence of "wrapped exception" in this file:
>> https://g
On Fri, 20 Aug 2021 22:44:34 GMT, Weijun Wang wrote:
> This change modifies the default value of the `java.security.manager` system
> property from "allow" to "disallow". This means unless it's explicitly set to
> "allow", any call to `System.setSecurityManager()` would throw an UOE.
>
> The `
On Fri, 20 Aug 2021 22:44:34 GMT, Weijun Wang wrote:
> This change modifies the default value of the `java.security.manager` system
> property from "allow" to "disallow". This means unless it's explicitly set to
> "allow", any call to `System.setSecurityManager()` would throw an UOE.
>
> The `
On 3/08/2021 2:25 am, Igor Ignatyev wrote:
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
Hi all,
could you please review this big tedious and trivial(-ish) patch which moves
`sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
the majority of the patch is the
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
>>
On Thu, 29 Jul 2021 01:30:37 GMT, Vladimir Kozlov wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
>
On Mon, 5 Jul 2021 06:01:23 GMT, Yi Yang wrote:
>> Class loading order is different to class initialization order.
>>
>> There are a lot more tests than just tier1. :) I don't expect many, if any,
>> tests to be looking for a specific IOOBE message, and I can't see an easy
>> way to find such
On 17/06/2021 8:50 pm, Alan Bateman wrote:
On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes wrote:
There are a lot more tests than just tier1. :) I don't expect many, if any,
tests to be looking for a specific IOOBE message, and I can't see an easy way
to find such tests without ru
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Class loading order is different to class initialization ord
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
I skimmed through all these and the changes seem fine in pri
On Mon, 7 Jun 2021 20:42:53 GMT, Weijun Wang wrote:
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
There are a number of hotspot tests that will trigger this warning, so please
ensure they work correctly with the extra
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Fri, 12 Mar 2021 16:44:38 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On 12/03/2021 5:12 pm, Anton Kozlov wrote:
On Fri, 12 Mar 2021 05:24:10 GMT, David Holmes wrote:
Anton Kozlov has updated the pull request incrementally with one additional
commit since the last revision:
8262903: [macos_aarch64] Thread::current() called on detached thread
src/hotspot
On Thu, 11 Mar 2021 14:07:43 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 2 Mar 2021 21:19:18 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 1 Feb 2021 22:41:16 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList these two tests on Linux:
>
> sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java
> sun/security/krb5/auto/ReplayCacheTestProc.java
>
> We're rolling machines over to Linux 8.3 and these two tests are
I don't know why the Skara tools decided to associate my comment with
Alan Hayward's comment as they are not at all related. :(
David
On 27/01/2021 4:50 pm, David Holmes wrote:
On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing
On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward
wrote:
>>> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
>>> framework
>>> ie:
>>> `--with-extra-ldflags='-F
>>> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fram
On 11/11/2020 9:19 pm, Jorn Vernee wrote:
On Wed, 11 Nov 2020 07:18:33 GMT, David Holmes wrote:
Maurizio Cimadamore has updated the pull request incrementally with 10
additional commits since the last revision:
- Merge pull request #7 from JornVernee/Additional_Review_Comments
On Tue, 10 Nov 2020 14:16:22 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On 10/11/2020 2:34 am, Jorn Vernee wrote:
On Mon, 9 Nov 2020 12:11:56 GMT, Jorn Vernee wrote:
I agree with Coleen.
I'll give this another try, but I think last time I tried this resolution of
the class failed when trying to build the JDK, seemingly since it exists in an
incubator module, w
On Mon, 9 Nov 2020 18:25:27 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393 [
Hi Jorn,
On 9/11/2020 9:57 pm, Jorn Vernee wrote:
On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote:
src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 99:
97: if (thread == NULL) {
98: JavaVM_ *vm = (JavaVM *)(&main_vm);
99: vm -> fu
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393 [
On Fri, 6 Nov 2020 21:42:41 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 64 commits:
>>
>> - Merge branch '8254162' into 8254231_linker
>> - Fix post-merge issues caused by
On Fri, 30 Oct 2020 12:16:02 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393 [
Hi Jorn,
I'm not reviewing this but this exchange caught my attention ...
On 16/10/2020 9:15 pm, Jorn Vernee wrote:
On Thu, 15 Oct 2020 22:42:49 GMT, Coleen Phillimore wrote:
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin wrote:
>> Marked as reviewed by kvn (Reviewer).
>
> Have you run the JFR tests in test/jdk/jdk/jfr?
@marschall Please do not force-push anything as it breaks the commit history in
the PR and renders previous
reviews/comments obsolete. There is no wa
On 10/09/2020 10:07 pm, Dmitriy Dumanskiy wrote:
On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote:
The code in java.base was updated to use String::isEmpty in JDK 12
(JDK-8215281). There was follow-up in JDK 13 to do
the same in the java.desktop module (JDK-8223237). Changing the
David
-
Cheers,
Sergey
17.09.2020, 14:11, "David Holmes" :
On 17/09/2020 7:24 pm, Сергей Цыпанов wrote:
Hi David,
thanks for pointing this out!
I've created a PR there [1], but GitHub for some reason wants me to sign OCA,
which I have already signed in 2017. I've r
y for the issue."
[1]
https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1
Cheers,
David
-
Regards,
Sergey
1. https://github.com/openjdk/jdk/pull/218
17.09.2020, 09:22, "David Holmes" :
Hi Sergey,
Since OpenJDK has moved to git/github, this needs to reform
Hi Sergey,
Since OpenJDK has moved to git/github, this needs to reformulated as a
Pull Request (PR).
Cheers,
David
On 17/09/2020 5:19 pm, Сергей Цыпанов wrote:
Hello,
is it possible to have a code review for the changes proposed in JDK-8251548?
Sean Mullan has created an issue and web-revi
On Thu, 10 Sep 2020 12:18:51 GMT, Kevin Rushforth wrote:
>> This should be broken up to deal with the files in different functional
>> areas under different bugids and PRs. Otherwise
>> the cross-posting to so many lists is prohibitive. Files in different areas
>> need to be reviewed by differe
On Thu, 10 Sep 2020 10:40:15 GMT, Alan Bateman wrote:
>> @kevinrushforth thanks. Done.
>>
>> Similar issues:
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=822
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
wrote:
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from
Hi Philippe,
On 8/09/2020 3:08 am, Philippe Marschall wrote:
Hello, newbie here
Welcome aboard!
I picked JDK-8138732 to work on because it has a "starter" label and I believe
I understand what to do.
- I tried to update the copyright year to 2020 in every file.
- I decided to change `@sinc
http://cr.openjdk.java.net/~stooke/webrevs/jdk-8243114-jdk/01/01/
All my comments have been addressed - thanks.
David
Thanks,
-Simon
On 2020-06-05 12:35 a.m., David Holmes wrote:
Hi Simon,
On 4/06/2020 11:35 pm, Simon Tooke wrote:
Hello, David, and thanks for the review!
I've responded to your comm
Hi Simon,
On 4/06/2020 11:35 pm, Simon Tooke wrote:
Hello, David, and thanks for the review!
I've responded to your comments below, and intend to post a new patch
for review today or tomorrow.
Thanks again,
-Simon
On 2020-06-03 2:06 a.m., David Holmes wrote:
Hi Simon,
On 23/05/20
Hi Simon,
On 23/05/2020 12:04 am, Sean Mullan wrote:
Cross-posting to hotspot-dev for additional review since the code
changes are in hotspot.
--Sean
On 5/21/20 1:24 PM, Simon Tooke wrote:
Hello,
I'd like to request a review for:
JBS: https://bugs.openjdk.java.net/browse/JDK-8243114
Webre
given how error-prone that can be, I still wouldn't do it in this changeset.
-Pavel
On 8 Apr 2020, at 13:56, David Holmes wrote:
Hi Pavel,
Not a review ...
On 8/04/2020 9:50 pm, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http:/
load
this webrev on cr.openjdk.java.net
Please suggest if there is any way I can create my user id to upload this patch.
This is ~300 line patch file.
Regards,
Vipin
On Apr 6, 2020, at 3:25 AM, David Holmes wrote:
Hi Vipin,
On 6/04/2020 6:42 am, Vipin Sharma wrote:
Hi,
I have fixed a few warni
Hi Christoph,
On 22/06/2019 2:25 pm, Langer, Christoph wrote:
Hi,
I pushed the backport of JDK-8148188 [0] to jdk11u-dev [1] on Friday. I was
wondering why no 11.0.5 backport JBS item was created. I then manually created
JDK-8226636 [2], but the minute I had created it I got an idea what the
Hi Max,
Not a review :)
On 30/05/2019 11:01 pm, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8193255/webrev.00/
Please pay attention to the 1st 3 and the last 2 files. Others are PEM files
for all certs inside the original cacerts.
There is one thing I c
Looks good! Thanks Daniel.
David
On 23/05/2019 7:32 pm, Daniel Fuchs wrote:
Hi,
Please find a patch below that temporarily problem lists
java/security/SecureClassLoader/DefineClass.java
on linux and windows until JDK-8224635 [1] is fixed:
8224656: Problem list java/security/SecureClassLoader/
o doPriv because the Java code
just invokes PrivilegedAction.run() now.
Okay. I'll either delete it or keep it, but won't move it.
Thanks,
David
--Sean
On 4/2/19 1:03 AM, David Holmes wrote:
Hi Security-libs team,
webrev: http://cr.openjdk.java.net/~dholmes/8213233/webrev/
bug:
Hi Security-libs team,
webrev: http://cr.openjdk.java.net/~dholmes/8213233/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8213233
Now that doPrivileged is Java-based these older runtime regression tests
don't really belong in runtime any longer. I'd like to hg move them to
test/jdk/java
m all -
myself included.
On Mon, Mar 25, 2019 at 1:34 AM David Holmes <mailto:david.hol...@oracle.com>> wrote:
Hi Thomas,
A few queries, comments and concerns ...
On 25/03/2019 6:58 am, Thomas Stüfe wrote:
> Hi all,
>
> After a long time I tried to b
tiveKeyInfo
function so I can see exactly what the instruction at 0x2e4 offset is
(for the build without this patch).
@David Holmes: even though wrappedKeySizeWrappedKeyArrayPtr may have an
unaligned value, looks to me that it's not directly used to access
memory but used through memcpy.
nor style nit:
725 if(env->ExceptionOccurred()) {
Please add a space after "if" (yes I see the macros have this wrong too).
No need for updated webrev.
Thanks,
David
Best regards, Matthias
-Original Message-----
From: David Holmes
Sent: Dienstag, 18. Dezember 2018 1
On 19/12/2018 6:52 am, dean.l...@oracle.com wrote:
David, can I list you as a reviewer?
No, sorry, I only commented on the general issue.
David
dl
On 12/16/18 8:47 PM, dean.l...@oracle.com wrote:
On 12/16/18 7:39 PM, dean.l...@oracle.com wrote:
On 12/16/18 7:03 PM, David Holmes wrote
and that is what the original code did.
If everything succeeds you should do the release with mode 0; but if
taking an error exit the release should use mode JNI_ABORT so no changes
are written back.
Cheers,
David
Best regards, Matthias
-Original Message-
From: David Holm
Correction ...
On 18/12/2018 8:25 am, David Holmes wrote:
Hi Matthias,
On 17/12/2018 6:59 pm, Baesken, Matthias wrote:
Hello, please review the following change.
I noticed that we miss at some places (for example in case of early
returns)
where GetByteArrayElements is used, the
Hi Matthias,
On 17/12/2018 6:59 pm, Baesken, Matthias wrote:
Hello, please review the following change.
I noticed that we miss at some places (for example in case of early returns)
where GetByteArrayElements is used, the corresponding ReleaseByteArrayElements
call.
In VirtualMachineImpl.c I
On 17/12/2018 12:49 pm, dean.l...@oracle.com wrote:
On 12/16/18 4:06 PM, David Holmes wrote:
On 15/12/2018 10:59 am, dean.l...@oracle.com wrote:
https://bugs.openjdk.java.net/browse/JDK-8214583
http://cr.openjdk.java.net/~dlong/8214583/webrev
This change includes two new regression test that
On 15/12/2018 10:59 am, dean.l...@oracle.com wrote:
https://bugs.openjdk.java.net/browse/JDK-8214583
http://cr.openjdk.java.net/~dlong/8214583/webrev
This change includes two new regression test that demonstrate the
problem, and a fix that allows the tests
to pass.
The problem happens when th
Hi Dean,
On 1/11/2018 10:13 AM, dean.l...@oracle.com wrote:
On 10/31/18 4:06 PM, David Holmes wrote:
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged
and related privileged_stack code seems okay. I have a few related
comments:
src/hotspot/share/classfile
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged and
related privileged_stack code seems okay. I have a few related comments:
src/hotspot/share/classfile/systemDictionary.hpp
You added the java_security_AccessController class after
java_security_AccessControlCont
Hi Max,
Thanks for fixing.
Reviewed.
David
JDK-8186186 added a new test called SpnegoUnknownMech.java [1]. It was named
SpnegoRejected.java but was renamed to the current name right before the push.
The content still references the old name and therefore cannot run.
Please review the patch
Ivan,
Did you forget to hg add a file for this? The new test is failing with:
Error. Parse Exception: Can't find source file: SpnegoRejected.java
David
On 22/08/2018 1:20 PM, ivan.gerasi...@oracle.com wrote:
Changeset: 0e4d87cf6caf
Author:igerasim
Date: 2018-08-21 20:19 -0700
URL:
On 29/06/2018 6:32 PM, Alan Bateman wrote:
On 29/06/2018 09:22, Sibabrata Sahoo wrote:
May I get the approval from serviceability-...@openjdk.java.net.
This a test only change to update the keystores and the list of
ciphers/protocols that the test uses. There's nothing serviceability
specific
On 20/01/2018 6:28 AM, Sean Mullan wrote:
I believe sunrsasign.jar was removed in JDK 1.5. So it seems like the
line below is no longer necessary and should be removed. I have copied
hotspot-dev to see if this is a known issue or if I am missing something.
As per Brad's filing of
https://bugs
On 3/06/2017 5:10 AM, Igor Ignatyev wrote:
On Jun 2, 2017, at 9:14 AM, Ioi Lam wrote:
On 6/2/17 8:44 AM, Ioi Lam wrote:
On 6/2/17 6:40 AM, Chris Hegarty wrote:
On 02/06/17 00:14, Ioi Lam wrote:
...
The gem is hidden in the compile.0.jta file. It contains something like:
-sourcepat
On 23/05/2017 10:45 PM, Volker Simonis wrote:
On Tue, May 23, 2017 at 10:51 AM, David Holmes wrote:
On 23/05/2017 6:20 PM, Alan Bateman wrote:
Volker - one suggestion for your experiments is to change your JDK 8
security properties file (java.security) to add "com.sun.crypto.provider
On 23/05/2017 6:20 PM, Alan Bateman wrote:
Volker - one suggestion for your experiments is to change your JDK 8
security properties file (java.security) to add
"com.sun.crypto.provider." to the value of the "package.access"
property. That should mean you will get the same AccessControlException
Hi Joe,
On 4/02/2017 5:21 AM, joe darcy wrote:
Hello,
After the version update to "10" in JDK 10 ( JDK-8029942 ), various
libraries tests failed including:
java/lang/module/MultiReleaseJarTest.java
java/security/Provider/ProviderVersionCheck.java
Shouldn't the hardwired 10.0d (was 9.
On 2/01/2017 9:45 PM, Claes Redestad wrote:
On 12/31/2016 12:45 AM, David Holmes wrote:
I'll let you think about it so more. I'll be back in the office on
Tuesday :)
After giving it some thought I think it's better to just document the need
for some hygiene in the field dec
On 31/12/2016 12:50 AM, Claes Redestad wrote:
Hi David,
On 2016-12-30 02:10, David Holmes wrote:
Hi Claes,
On 28/12/2016 12:04 AM, Claes Redestad wrote:
Hi,
since java.util.concurrent.AtomicReference was changed to use a
VarHandle internally, using it from within the security libraries can
Hi Claes,
On 28/12/2016 12:04 AM, Claes Redestad wrote:
Hi,
since java.util.concurrent.AtomicReference was changed to use a
VarHandle internally, using it from within the security libraries can
lead to hard to diagnose bootstrap cycles (since VarHandles has to do
doPrivileged calls during setup
Hi Chris,
I would have expected some tests to need modifying here (or other places!).
David
On 14/01/2016 8:05 PM, Chris Hegarty wrote:
The "stopThread” RuntimePermission is granted by default. The Thread.stop
methods have been deprecated for more than 15 years. It seems reasonable,
in a major
Hi Chris,
Hotspot comment change looks okay.:)
I see a lot of hotspot tests that include
@modules java.base/sun.misc
but I don't understand why it is present in the few cases I looked at eg:
hotspot/test/gc/g1/TestShrinkAuxiliaryData15.java
so not sure when it needs to be converted to jdk.in
Hi Tony,
Not a review as hotspot compiler folk need to review this.
On 17/02/2015 7:11 AM, Anthony Scarpino wrote:
Hi,
I'm requesting a code review to intrinsify the GHASH operations for both
x86 and SPARC platforms. This greatly increases performance over
software for AES/GCM crypto operatio
On 12/02/2015 2:10 AM, Jaroslav Bachorik wrote:
Please, review the following simple change.
Issue : https://bugs.openjdk.java.net/browse/JDK-8072932
Webrev: http://cr.openjdk.java.net/~jbachorik/8072932/webrev.00
This patch is about replacing the
j.s.AccessControlContext.getDomainCombiner() wit
Hi Max,
On 2/07/2014 1:46 PM, Wang Weijun wrote:
Hi All
Please review the fix at
http://cr.openjdk.java.net/~weijun/8047765/webrev.00/
where the generation of blacklisted.certs is moved from developer-manual to
build-auto. I copied the mechanisms from GENDATA_HTML32DTD.
Seems like a re
Changeset: 23982079ad49
Author:dholmes
Date: 2013-11-04 07:39 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23982079ad49
8027755: Anti-delta incorrect push for 8025198
Reviewed-by: alanb
! makefiles/CompileLaunchers.gmk
! makefiles/lib/CoreLibraries.gmk
! src/share/bin/java
On 4/11/2013 10:35 PM, Alan Bateman wrote:
On 04/11/2013 12:10, David Holmes wrote:
My commit pulled in a bunch of local changes that should never have
been pushed (the import commit failed due to whitespace and when I
re-issued the commit I didn't restrict it to the single test file).
My commit pulled in a bunch of local changes that should never have been
pushed (the import commit failed due to whitespace and when I re-issued
the commit I didn't restrict it to the single test file).
Can anyone roll this back on the actual server?
Thanks,
David
Original Message --
Changeset: d19ab5da83cc
Author:dholmes
Date: 2013-11-04 06:58 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc
8025198: Intermittent test failure:
java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java
Reviewed-by: martin, dholmes
Contributed-by: Tristan Yan
Changeset: e33aea66caa3
Author:dholmes
Date: 2013-10-15 20:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33aea66caa3
8026378: TEST_BUG: Clean up TEST.groups
Reviewed-by: mduigou, mchung, alanb
! test/TEST.groups
Changeset: 254173b48dcb
Author:dholmes
Date: 2013-10-10 04:57 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/254173b48dcb
8026232: Move libnpt from profile compact1 to compact3
Reviewed-by: mchung, alanb
! makefiles/profile-includes.txt
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show correct use of try-with-reso
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build changes and a new build tool to add additional
restricted packages to the java.security file which are
nge how we assign that permission then you would still require it and
wouldn't have it unless using a custom security policy - which would
allow you to deal with the modifyThread permission too.
David
-
On Wed, Oct 2, 2013 at 9:03 PM, David Holmes wrote:
On 3/10/2013 1:55 PM, Martin
On 3/10/2013 1:55 PM, Martin Buchholz wrote:
On Wed, Oct 2, 2013 at 7:13 PM, David Holmes wrote:
On 3/10/2013 2:54 AM, Martin Buchholz wrote:
On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart
wrote:
Hi Martin,
If you want to optimize for without-security-manager case
I want to optimize
On 3/10/2013 2:54 AM, Martin Buchholz wrote:
On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart wrote:
Hi Martin,
If you want to optimize for without-security-manager case
I want to optimize for the case that Thread.interrupt does not throw
SecurityException
How is your proposal optimizing tha
On 3/10/2013 3:02 AM, Doug Lea wrote:
On 10/02/2013 12:29 PM, Martin Buchholz wrote:
FutureTask.cancel(true) invokes thread.interrupt on the thread (if any)
currently running the task.
This should succeed even if modifyThread permission is denied by the
security
manager.
We haven't interprete
Changeset: 2cdd1078f45b
Author:dholmes
Date: 2013-09-03 23:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cdd1078f45b
8024140: [TESTBUG] Profile based regression test groups for jdk repo
Reviewed-by: alanb, chegar
! test/TEST.groups
Changeset: 9586ca82bd8b
Author:bpittore
Date: 2013-08-26 11:27 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9586ca82bd8b
8014135: The JVMTI specification does not conform to recent changes in JNI
specification
Summary: Added support for statically linked agents
Reviewed-by
Changeset: 3b8fed46b2a8
Author:dholmes
Date: 2013-08-21 05:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8fed46b2a8
8023460: OPENJDK build fails due to missing jfr.jar
Reviewed-by: alanb
! makefiles/Profiles.gmk
1 - 100 of 164 matches
Mail list logo
