Re: Code review request: 8004235: Disable native JGSS provider on Mac

2012-12-07 Thread Kelly O'Hair
Looks ok to me. Thanks. -kto On Dec 7, 2012, at 2:39 AM, Weijun Wang wrote: The native JGSS provider on Mac is not ready yet. Disable the native lib creation. Please review the code changes at http://cr.openjdk.java.net/~weijun/8004235/webrev.00/ *build-dev*: I don't know how to

Re: code review request: 7083664: test hard code of using c:/temp but this dir might not exist

2011-08-30 Thread Kelly O'Hair
Looks ok to me. -kto On Aug 30, 2011, at 12:34 AM, Weijun Wang wrote: Hi All 7083664: test hard code of using c:/temp but this dir might not exist Webrev is at -- http://cr.openjdk.java.net/~weijun/7083664/webrev.00/ Some of our regression tests set TMP variables on different

Re: 2nd round code review request: 7055363: jdk_security3 cleanup

2011-08-04 Thread Kelly O'Hair
On Aug 4, 2011, at 11:06 AM, Weijun Wang wrote: Max, if we can get an agree, would you please update the Makefile to run JSSE in othervm mode in your fix? So that we don't have to fill a new CR. There are two ways to do this: 1. Add @run main/othervm to all JSSE tests. This means a lot

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Kelly O'Hair
On Jan 21, 2011, at 7:08 AM, Vincent Ryan wrote: On 21/01/2011 14:42, Alan Bateman wrote: Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code:

Re: review request for 7005608: diamond conversion of JCA and crypto providers

2010-12-23 Thread Kelly O'Hair
On Dec 23, 2010, at 6:17 PM, Brad Wetmore wrote: On 12/23/2010 12:58 PM, Mandy Chung wrote: On 12/23/10 12:40 PM, Stuart Marks wrote: On 12/22/10 6:17 PM, Brad Wetmore wrote: You need to update the Copyright updates on these files to include 2010. Is this the standard, to update the