Re: Code review request: 7064075 Security libraries don't build with javac -Xlint:all, -deprecation -Werror

2011-07-20 Thread xuelei....@oracle.com
On Jul 21, 2011, at 1:25 AM, Alexandre Boulgakov wrote: > This is a Netbeans warning, not generated by the compiler. The reason is that > List.isEmpty() can be more efficient for some implementations. > ArrayList.size() == 0 and ArrayList.isEmpty() should take the same time, so > it doesn't

Re: On 7063702: To interprete case-insensitive string locale independently

2011-07-07 Thread xuelei....@oracle.com
On Jul 7, 2011, at 4:30 PM, Weijun Wang wrote: > Hi Xuelei > > There are some other places using equalsIgnoreCase(). Is this method safe for > all locales? > equalsIgnoreCase() is safe. Looking into the code of this method, you will find that the implementation is a little different from ju

Re: On 7063702: To interprete case-insensitive string locale independently

2011-07-07 Thread xuelei....@oracle.com
I did not check all directories. I think we may need to evaluate them in the same CR or according to modules. Andrew On Jul 7, 2011, at 4:30 PM, Weijun Wang wrote: > Hi Xuelei > > There are some other places using equalsIgnoreCase(). Is this method safe for > all locales? > > Thanks > Max

Re: Code review request: 7059709, java/jsse, close the IO in a final block

2011-06-29 Thread xuelei....@oracle.com
I found the bug when I was learning the t-w-r feature. But just as Stuart thoroughly analysis, I failed to find a easy way to use t-w-r for these two updates. Thanks for all of the feedback. Xuelei On Jun 29, 2011, at 6:44 AM, Brad Wetmore wrote: > While I was thinking the same thing as Sea

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-29 Thread xuelei....@oracle.com
gt;Are you using JDK 7? There were some bugs fixed with indirect CRLs in JDK > 7. > > Also, make sure you set the system property com.sun.security.enableCRLDP > to the >value true when running, ex: java -Dcom.sun.security.__enableCRLDP=true ... > >

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-27 Thread xuelei....@oracle.com
Can you provide the code to reproduce the exception? Or is it possible attach the CertPath building debugger log? Xuelei On Jun 28, 2011, at 11:59 AM, David Pomeroy wrote: > Hello All, > > I am trying to get a servlet to download and check a CRL. The CRLDP is in > the client's certificate a