Re: [11] RFR 8202837: PBES2 AlgorithmId encoding error in PKCS12 KeyStore

2018-07-18 Thread Xuelei Fan
Looks fine to me except a minor nit. PBES2Parameters.java: - 282 String kdfAlgo = "HmacSHA1"; // default I may suggest you move the declaration down to line 314. It is clear about what the "default" means. Xuelei On 7/18/2018 1:57 AM, Weijun Wang wrote: Please t

[11] RFR 8202837: PBES2 AlgorithmId encoding error in PKCS12 KeyStore

2018-07-18 Thread Weijun Wang
Please take a review at JBS: https://bugs.openjdk.java.net/browse/JDK-8202837 Fix: http://cr.openjdk.java.net/~weijun/8202837/webrev.00/ The redundant encoding/decoding of the extra PBES2 OID is removed. The encoding/decoding of keyLength and prf in PBKDF2-params is also made optional-awa