Re: [15] RFR: 8242335: Additional Tests for RSASSA-PSS

Updated webrev looks fine. Thanks, Valerie On 5/3/2020 11:27 PM, sibabrata.sa...@oracle.com wrote: Hi Valerie, Here is the updated web rev addressing the following comments. There are 7 lines of additional change added [Line: 126-133] to re-verify the signature with another Signature

Re: [15] RFR: 8242335: Additional Tests for RSASSA-PSS

Hi Valerie, Here is the updated web rev addressing the following comments. There are 7 lines of additional change added [Line: 126-133] to re-verify the signature with another Signature instance. Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.01/

Re: [15] RFR: 8242335: Additional Tests for RSASSA-PSS

Hi, Siba, Here are my comments: - Typos: Initialisation -> Initialization. - the 2nd algorithm specific initialization using reflection doesn't seem too useful. The code path should be exactly the same as the non-reflection one. Maybe just remove it. Rest looks fine. Thanks, Valerie On

[15] RFR: 8242335: Additional Tests for RSASSA-PSS

Hi Valerie, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8242335 Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/ These are additional Tests