Re: [8] code review for 8007755: Support the logical grouping of keystores

2013-02-13 Thread Vincent Ryan
On 13/02/2013 19:10, Sean Mullan wrote: On 02/13/2013 01:22 PM, Vincent Ryan wrote: Latest webrev: http://cr.openjdk.java.net/~vinnie/8007755/webrev.01/ Looks good. Also, this will require a CCC, so you won't be able to fix this now, but the DomainLoadStoreParameter should be a standalo

Re: [8] code review for 8007755: Support the logical grouping of keystores

2013-02-13 Thread Sean Mullan
On 02/13/2013 01:22 PM, Vincent Ryan wrote: Latest webrev: http://cr.openjdk.java.net/~vinnie/8007755/webrev.01/ Looks good. Also, this will require a CCC, so you won't be able to fix this now, but the DomainLoadStoreParameter should be a standalone class, since it is keystore-type speci

Re: [8] code review for 8007755: Support the logical grouping of keystores

2013-02-13 Thread Vincent Ryan
Latest webrev: http://cr.openjdk.java.net/~vinnie/8007755/webrev.01/ On 13/02/2013 16:47, Sean Mullan wrote: Overall this looks good, just have a few comments: * KeyStore [313-317] You should state what the String keys are supposed to contain (i.e. keystore aliases). Done. [329] Yo

Re: [8] code review for 8007755: Support the logical grouping of keystores

2013-02-13 Thread Sean Mullan
Overall this looks good, just have a few comments: * KeyStore [313-317] You should state what the String keys are supposed to contain (i.e. keystore aliases). [329] You need to make a copy of the Map before wrapping it in an unmodifiable Map. Also, this will require a CCC, so you won't be

[8] code review for 8007755: Support the logical grouping of keystores

2013-02-07 Thread Vincent Ryan
Please review this final component of JEP-166 that adds support for logical keystores and introduces a new keystore type called DKS, the domain keystore. The purpose of the domain keystore is to simplify the handling of multiple keystores and truststores for applications and to ease their deploy