On 17/05/19 17:58, Severin Gehwolf wrote:
Thanks! How about this?
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203190/03/webrev/
Yes, the test looks good to me!
Thanks Severin,
best regards,
-- daniel
On 5/16/19 7:51 PM, Severin Gehwolf wrote:
> Could I please get a review of this OpenJDK 8u only fix? JDKs 11+ don't
> seems to have this issue as with the TLS 1.3 feature (JDK-8196584)
> SessionId.hashCode() got changed to use Arrays.hashCode() already.
>
> webrev: http://cr.openjdk.java.net/~sge
Hi Daniel,
On Fri, 2019-05-17 at 17:15 +0100, Daniel Fuchs wrote:
> Hi Severin,
>
> Here is an example of a manual test checked in in the jdk repo:
>
> http://hg.openjdk.java.net/jdk/jdk/file/tip/test/jdk/sun/security/provider/PolicyParser/ExtDirs.java
>
> - it has an @test annotation
> - it ha
Hi Severin,
Here is an example of a manual test checked in in the jdk repo:
http://hg.openjdk.java.net/jdk/jdk/file/tip/test/jdk/sun/security/provider/PolicyParser/ExtDirs.java
- it has an @test annotation
- it has an @bug annotation
- it has an @run main/manual line
- it has a comment explaini
On 17/05/2019 17:00, Severin Gehwolf wrote:
> On Fri, 2019-05-17 at 16:28 +0100, Andrew John Hughes wrote:
>>
>> On 17/05/2019 12:37, Severin Gehwolf wrote:
>>
>> snip...
>>
>>> The reason was that it's not a good test to be run automatically. It
>>> would have to have some heuristic which it use
On Fri, 2019-05-17 at 16:28 +0100, Andrew John Hughes wrote:
>
> On 17/05/2019 12:37, Severin Gehwolf wrote:
>
> snip...
>
> > The reason was that it's not a good test to be run automatically. It
> > would have to have some heuristic which it uses as "passed" and "fail".
> > Checking in the code
On 17/05/2019 12:37, Severin Gehwolf wrote:
snip...
>
> The reason was that it's not a good test to be run automatically. It
> would have to have some heuristic which it uses as "passed" and "fail".
> Checking in the code anyway has a tendency for it to bitrot. If you
> really feel strongly ab
On Fri, 2019-05-17 at 12:07 +0200, Aleksey Shipilev wrote:
> On 5/16/19 7:51 PM, Severin Gehwolf wrote:
> > Could I please get a review of this OpenJDK 8u only fix? JDKs 11+ don't
> > seems to have this issue as with the TLS 1.3 feature (JDK-8196584)
> > SessionId.hashCode() got changed to use Arra
On Thu, 2019-05-16 at 19:10 +0100, Andrew John Hughes wrote:
>
> Change looks good.
Thanks for the review.
> Is there a reason the tests aren't included in the webrev? I think it
> would be better to have them checked in, even if they can't be run
> automatically.
The reason was that it's not a
On 16/05/2019 18:51, Severin Gehwolf wrote:
> Hi,
>
> Could I please get a review of this OpenJDK 8u only fix? JDKs 11+ don't
> seems to have this issue as with the TLS 1.3 feature (JDK-8196584)
> SessionId.hashCode() got changed to use Arrays.hashCode() already.
>
> webrev: http://cr.openjdk.jav
Hi,
Could I please get a review of this OpenJDK 8u only fix? JDKs 11+ don't
seems to have this issue as with the TLS 1.3 feature (JDK-8196584)
SessionId.hashCode() got changed to use Arrays.hashCode() already.
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203190/01/webrev/
Bug: https:
11 matches
Mail list logo
