Re: [9] RFR: 8007706: X.509 cert extension SAN should support "_" in dNSName

2014-08-05 Thread Jason Uh
Thanks, Florian. I will withdraw my review request and close this issue. I'll file a separate bug to allow the first character to be a digit, as RFC 1123 relaxed that restriction. Thanks, Jason On 08/04/2014 11:58 PM, Florian Weimer wrote: On 08/05/2014 07:52 AM, Jason Uh wrote: Hi Florian,

Re: [9] RFR: 8007706: X.509 cert extension SAN should support "_" in dNSName

2014-08-04 Thread Florian Weimer
On 08/05/2014 07:52 AM, Jason Uh wrote: Hi Florian, I've reviewed the RFC again and think there might be some misinterpretation. The only part I see about underscores reads: Implementers should note that the at sign ('@') and underscore ('_') characters are not supported by the ASN.1 typ

Re: [9] RFR: 8007706: X.509 cert extension SAN should support "_" in dNSName

2014-08-04 Thread Jason Uh
Hi Florian, I've reviewed the RFC again and think there might be some misinterpretation. The only part I see about underscores reads: Implementers should note that the at sign ('@') and underscore ('_') characters are not supported by the ASN.1 type PrintableString. These characters

Re: [9] RFR: 8007706: X.509 cert extension SAN should support "_" in dNSName

2014-08-04 Thread Florian Weimer
On 08/02/2014 04:09 AM, Jason Uh wrote: Hi Florian, Thanks for your input. There was some discussion about the issue in the past on this list: http://mail.openjdk.java.net/pipermail/security-dev/2013-February/006622.html Do you disagree with the comments there? I think the intent of RFC 528

Re: [9] RFR: 8007706: X.509 cert extension SAN should support "_" in dNSName

2014-07-22 Thread Florian Weimer
On 07/22/2014 09:52 AM, Jason Uh wrote: Hi Max, Could you please review this fix? http://cr.openjdk.java.net/~juh/8007706/webrev.00/ With the fix, the rules will be: 1. A DNSName must begin with a letter or a digit 2. After the first character, valid characters in DNSName components are letter

[9] RFR: 8007706: X.509 cert extension SAN should support "_" in dNSName

2014-07-22 Thread Jason Uh
Hi Max, Could you please review this fix? http://cr.openjdk.java.net/~juh/8007706/webrev.00/ With the fix, the rules will be: 1. A DNSName must begin with a letter or a digit 2. After the first character, valid characters in DNSName components are letters, digits, hyphens, and underscores A