Re: [9] RFR: 8048356: SecureRandom default provider tests

2015-11-09 Thread Bradford Wetmore
Ok, thanks. Looks fine. brad On 11/9/2015 2:13 PM, Rajan Halade wrote: Thanks for the comments, Brad. I have addressed those here - http://cr.openjdk.java.net/~rhalade/8048356/webrev.01/ I plan to have this test to check for default provider only so SecureRandom.getInstance(algorithm, provi

Re: [9] RFR: 8048356: SecureRandom default provider tests

2015-11-09 Thread Rajan Halade
Thanks for the comments, Brad. I have addressed those here - http://cr.openjdk.java.net/~rhalade/8048356/webrev.01/ I plan to have this test to check for default provider only so SecureRandom.getInstance(algorithm, provider) API is not good fit here. I think there are other tests which use thi

Re: [9] RFR: 8048356: SecureRandom default provider tests

2015-11-09 Thread Bradford Wetmore
On 9/4/2015 1:43 PM, Rajan Halade wrote: Please help with your review of this new test to check default provider used with SecureRandom. Bug: https://bugs.openjdk.java.net/browse/JDK-8048356 Webrev: http://cr.openjdk.java.net/~rhalade/8048356/webrev.00/ 51: Minor nit, you might reverse the

Re: [9] RFR: 8048356: SecureRandom default provider tests

2015-09-14 Thread Bradford Wetmore
I might also suggest grabbing a byte from the various implementations to ensure they return working implementations. You should also include a comment which mentions that this is an implementation-specific test for the Oracle & stock OpenJDK implementations, and that other implementations migh

[9] RFR: 8048356: SecureRandom default provider tests

2015-09-04 Thread Rajan Halade
Please help with your review of this new test to check default provider used with SecureRandom. Bug: https://bugs.openjdk.java.net/browse/JDK-8048356 Webrev: http://cr.openjdk.java.net/~rhalade/8048356/webrev.00/ Thanks, Rajan