http://cr.openjdk.java.net/~juh/8054037/02/
Looks good.
regards,
Sean.
On 03/03/2015 18:25, Jason Uh wrote:
Thanks for catching that. Here it is with the HandshakeMessage.java
changes.
I'll push with both bug IDs.
On 03/03/2015 01:25 AM, Seán Coffey wrote:
Jason,
I think you're missing th
Thanks for catching that. Here it is with the HandshakeMessage.java changes.
I'll push with both bug IDs.
On 03/03/2015 01:25 AM, Seán Coffey wrote:
Jason,
I think you're missing the HandshakeMessage.java changes that Vinnie
proposed. Everything else looks good to me.
I'd suggest that you push
Jason,
I think you're missing the HandshakeMessage.java changes that Vinnie
proposed. Everything else looks good to me.
I'd suggest that you push your changeset with both the 8054037 and
8055207 bug IDs then.
regards,
Sean.
On 02/03/2015 23:07, Jason Uh wrote:
Thanks for the comments, Sean;
Thanks for the comments, Sean; Vinnie, for the patch.
Here's an updated webrev with your suggested changes and Vinnie's patch.
http://cr.openjdk.java.net/~juh/8054037/01/
I've also removed a few unnecessary toString() calls in
AdaptableX509CertSelector.java and DistributionPointFetcher.java.
On 2 Mar 2015, at 17:26, Seán Coffey wrote:
> Jason,
>
> thanks for taking this on. Your changes look fine to be and should help the
> debugging experience. Some extra comments from me. Here's some standard
> output that one sees (early in connection) from a standard TLS connection
> attempt
Jason,
thanks for taking this on. Your changes look fine to be and should help
the debugging experience. Some extra comments from me. Here's some
standard output that one sees (early in connection) from a standard TLS
connection attempt with verbose certpath logging :
certpath: PKIXCertPath
Hi Jason,
I just spotted this thread now. Thanks for taking this on. I'd like to
do some testing with your new patch and get back to you tomorrow. Will
update then!
regards,
Sean.
On 13/02/2015 00:05, Jason Uh wrote:
Please review this change, which augments some of the debug statements
for
Please review this change, which augments some of the debug statements
for java.security.debug=certpath.
webrev: http://cr.openjdk.java.net/~juh/8054037/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8054037
Thanks,
Jason