I don't like it, but as the 1st stage of the improvement, it looks fine
to me.
Xuelei
On 11/16/2016 10:52 AM, Xuelei Fan wrote:
I don't like it, too. It is not necessary to make the merge in a hurry.
Maybe, we can wait for a while so that we have time for a real and
comfortable template.
Th
I don't like it, too. It is not necessary to make the merge in a hurry.
Maybe, we can wait for a while so that we have time for a real and
comfortable template.
Thanks,
Xuelei
On 11/16/2016 10:44 AM, Artem Smotrakov wrote:
I don't like it, but no lambdas, no nothing in SSLSocketTemplate.jav
I don't like it, but no lambdas, no nothing in SSLSocketTemplate.java
http://cr.openjdk.java.net/~asmotrak/8168969/webrev.01/
Xuelei,
Could you please take a look?
Artem
On 11/02/2016 09:14 AM, Artem Smotrakov wrote:
Hi Xuelei,
This totally makes sense. But in my opinion we should use new
Hi John,
On 11/02/2016 05:36 PM, John Jiang wrote:
Correct, AnonCipherWithWantClientAuth can work fine without extending
SSLSocketTemplate.
I make those classes to extend SSLSocketTemplate to make lines
shorter (we keep lines shorter than 80 symbols).
In practice, you could divide one line to
Hi Artem,
On 2016/11/2 23:54, Artem Smotrakov wrote:
Hi John,
Please see inline.
On 11/01/2016 11:48 PM, John Jiang wrote:
Hi Artem,
Thanks for making the template to be used easily.
The tests in your patch extend class SSLSocketTemplate, but
SSLSocketTemplate looks like an utility class,
Hi Xuelei,
This totally makes sense. But in my opinion we should use new features
and APIs because:
- they are here to make code readable (okay, not to much lambdas)
- they help to avoid bugs (e.g., forgetting to close resources)
- we implicitly provide test coverage for new APIs
- we give exam
Hi John,
Please see inline.
On 11/01/2016 11:48 PM, John Jiang wrote:
Hi Artem,
Thanks for making the template to be used easily.
The tests in your patch extend class SSLSocketTemplate, but
SSLSocketTemplate looks like an utility class, but not a parent class.
For example,
test/sun/security
Please use JDK 6 only features (no Lambda, try-with-resource,
multi-catch, java.util.Objects, etc.) so as to expedite porting to
previous releases.
It would be nice if removing the part to declare the store files in each
sub-classes.
Xuelei
On 11/2/2016 2:48 PM, John Jiang wrote:
Hi Artem,
Hi Artem,
Thanks for making the template to be used easily.
The tests in your patch extend class SSLSocketTemplate, but
SSLSocketTemplate looks like an utility class, but not a parent class.
For example,
test/sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java
67 new S
Hello,
Please review the following patch which merges a couple of classes in
javax/net/ssl/templates.
SSLTest class contains re-usable parts of SSLSocketSample.
SSLSocketTemplate class is buggy (tests which follows it may fail
intermittently). I basically replaced SSLSocketTemplate with SSLT
10 matches
Mail list logo
