Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-08 Thread Sean Mullan
On 07/08/2016 11:23 AM, Wang Weijun wrote: Hi Tim Are we seeing new failures in these tests? I am asking this question because once upon a time (4 years ago) I was involved in several RFEs [1][2][3] to do some similar the same cleanup. Some tests were put into othervm mode, but for most others,

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-08 Thread Wang Weijun
Hi Tim Are we seeing new failures in these tests? I am asking this question because once upon a time (4 years ago) I was involved in several RFEs [1][2][3] to do some similar the same cleanup. Some tests were put into othervm mode, but for most others, we tried our best to make them runnable i

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-08 Thread Sean Mullan
Looks fine. --Sean On 07/07/2016 05:11 AM, Tim Du wrote: Hi Sean: Thank you for reviewing the codes. I updated the title for this bug and added othervm for the tests that add but not remove their own provider. Also corrected the typo. New webrev is available here: http://cr.openjdk.java.net/~t

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-07 Thread Tim Du
Updated copyright , new webrev here: http://cr.openjdk.java.net/~tidu/7052815/webrev.02/ Please help to review them ,Thanks. Regards Tim On 2016/7/8 1:30, Rajan Halade wrote: Hi Tim, Please also update the copyright year to 2016 wherever applicable. Thanks, Rajan On 7/7/16 2:11 AM, Tim Du w

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-07 Thread Rajan Halade
Hi Tim, Please also update the copyright year to 2016 wherever applicable. Thanks, Rajan On 7/7/16 2:11 AM, Tim Du wrote: Hi Sean: Thank you for reviewing the codes. I updated the title for this bug and added othervm for the tests that add but not remove their own provider. Also corrected th

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-07 Thread Tim Du
Hi Sean: Thank you for reviewing the codes. I updated the title for this bug and added othervm for the tests that add but not remove their own provider. Also corrected the typo. New webrev is available here: http://cr.openjdk.java.net/~tidu/7052815/webrev.01/ . Please help to review it again.