Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-18 Thread Erik Joelsson
One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Pengvalerie.p...@oracle.com wrote: Updated the

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-18 Thread Valerie Peng
Ok, thanks! Valerie On 8/18/2015 12:34 AM, Erik Joelsson wrote: One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM,

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-17 Thread Erik Joelsson
Build changes still look good. /Erik On 2015-08-15 01:30, Valerie Peng wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-17 Thread Valerie Peng
Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Pengvalerie.p...@oracle.com wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks,

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-14 Thread Erik Joelsson
Build changes look good. /Erik On 2015-08-14 04:31, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-14 Thread Sean Mullan
Couple of minor comments on ProviderConfig.java 183: you can use the diamond operator for anonymous classes now (PrivilegedAction). You could also use a lambda expression here but I'll leave that up to you. 193: the braces around if (debug != null) are not indented properly Looks fine

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-14 Thread Mandy Chung
On Aug 13, 2015, at 7:31 PM, Valerie Peng valerie.p...@oracle.com wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-14 Thread Valerie Peng
Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-14 Thread Mandy Chung
Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Peng valerie.p...@oracle.com wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move

[9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-13 Thread Valerie Peng
Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of