Re: [JDK 9] RFR: 8041781: Need new regression tests for PBE keys

2014-06-26 Thread Xuelei Fan
Looks fine to me. Would you like also add tests for PBEMAC, e.g., PBEWithHmacSHA1? Thanks, Xuelei On 6/27/2014 5:02 AM, Rajan Halade wrote: Ping...can someone help review this please. Thanks, Rajan On 6/18/14, 3:36 PM, Rajan Halade wrote: May I request you to review these 3 new tests to be a

Re: [JDK 9] RFR: 8041781: Need new regression tests for PBE keys

2014-06-26 Thread Rajan Halade
Ping...can someone help review this please. Thanks, Rajan On 6/18/14, 3:36 PM, Rajan Halade wrote: May I request you to review these 3 new tests to be added for PBE keys. New tests are added to address following: - seal/unseal works correctly with PBE algorithms - key wrapper works correctly w

[JDK 9] RFR: 8041781: Need new regression tests for PBE keys

2014-06-18 Thread Rajan Halade
May I request you to review these 3 new tests to be added for PBE keys. New tests are added to address following: - seal/unseal works correctly with PBE algorithms - key wrapper works correctly with PBEKey - SecretKeyFactory.translateKey() method works JDK Issue: https://bugs.openjdk.java.net/b