[PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-03-05 Thread Tobias Wagner
Hi Valerie and Tomas, thanks for the hint about SoftHSM. I just found the time to test it. I was able to run TestECDH using it with a SoftHSM2 based SunPKCS11 provider. I did not hear anything about my last response - so I hope, this it might be helpful. I wonder if there is anything left to

AW: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-02-09 Thread Tobias Wagner
rovider SunPKCS11-NSS (28 ms). ... Regards, Tobias -Ursprüngliche Nachricht- > Von:Valerie Peng <valerie.p...@oracle.com> > Gesendet: Fre 9 Februar 2018 02:03 > An: Tobias Wagner <tobias.wag...@n-design.de>; security-dev@openjdk.java.net > Betreff: Re: [PATCH]: Support

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-02-09 Thread Tomas Gustavsson
Valerie > > On 1/17/2018 3:02 PM, Tobias Wagner wrote: >> -Ursprüngliche Nachricht- >>> Von:Adam Petcher <adam.petc...@oracle.com> >>> Gesendet: Die 16 Januar 2018 18:38 >>> An: security-dev@openjdk.java.net >>> Betreff: Re: [PATCH]

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-02-08 Thread Valerie Peng
... Regards, Valerie On 1/17/2018 3:02 PM, Tobias Wagner wrote: -Ursprüngliche Nachricht- Von:Adam Petcher <adam.petc...@oracle.com> Gesendet: Die 16 Januar 2018 18:38 An: security-dev@openjdk.java.net Betreff: Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC Great!

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-19 Thread Adam Petcher
On 1/18/2018 2:57 PM, Adam Petcher wrote: I applied your patch and ran some initial tests, and everything looks good so far. I'm running the the regression tests on all platforms, and I'll let you know how it goes. Regression tests passed, and this patch is ready to be reviewed.

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-18 Thread Adam Petcher
I applied your patch and ran some initial tests, and everything looks good so far. I'm running the the regression tests on all platforms, and I'll let you know how it goes. We need a JDK Reviewer to review and approve the code, so I'm hoping someone will volunteer to take a look. For the

[PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-17 Thread Tobias Wagner
-Ursprüngliche Nachricht- > Von:Adam Petcher <adam.petc...@oracle.com> > Gesendet: Die 16 Januar 2018 18:38 > An: security-dev@openjdk.java.net > Betreff: Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC > > Great! I took a look at the patch,

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-16 Thread Adam Petcher
Great! I took a look at the patch, and I have some comments, the first of which probably needs to be addressed before I can test the change: 1) Is this patch against the http://hg.openjdk.java.net/jdk/jdk repository? I suspect it isn't because some of the paths are different than what I

[PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-12 Thread Tobias Wagner
Hi, here is the next patch for brainpool curve support in SunEC. Differences from the first patch: * Brainpool curves with less than 256 bits are removed. Subsequently, the curve oid check is made more robust to avoid null pointer caused Segmentation Faults in memcmp calls. * Bug JDK-8189594

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-04 Thread Adam Petcher
On 1/4/2018 7:42 AM, Tobias Wagner wrote: Hi and a happy new year, I did some further work reagarding the brainpool curves. For the points about the removal of the small curves and the challenges with that, please see below. Regarding the test vectors for the brainpool curves, I'm planning

[PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-04 Thread Tobias Wagner
r <adam.petc...@oracle.com> > >> Gesendet: Fre 15 Dezember 2017 20:57 > >> An: security-dev@openjdk.java.net > >> Betreff: Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC > >> 4) How important are the 224-bit and smaller curves? We c

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2017-12-18 Thread Adam Petcher
On 12/16/2017 2:52 PM, Tobias Wagner wrote: -Ursprüngliche Nachricht- Von:Adam Petcher <adam.petc...@oracle.com> Gesendet: Fre 15 Dezember 2017 20:57 An: security-dev@openjdk.java.net Betreff: Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC 4) How important are t

[PATCH]: Support for brainpool curves from CurveDB in SunEC

2017-12-16 Thread Tobias Wagner
-Ursprüngliche Nachricht- > Von:Adam Petcher <adam.petc...@oracle.com> > Gesendet: Fre 15 Dezember 2017 20:57 > An: security-dev@openjdk.java.net > Betreff: Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC > > On 12/15/2017 11:31 AM, Tobias

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2017-12-15 Thread Adam Petcher
On 12/15/2017 11:31 AM, Tobias Wagner wrote: Hi, in our current project, we have the requirement to support brainpool curves for TLS connections (RFC 7027). As part of this requirement, we introduced the brainpoolP*r1 curves to SunEC, as they are already known in sun.security.util.CurveDB.

[PATCH]: Support for brainpool curves from CurveDB in SunEC

2017-12-15 Thread Tobias Wagner
Hi, in our current project, we have the requirement to support brainpool curves for TLS connections (RFC 7027). As part of this requirement, we introduced the brainpoolP*r1 curves to SunEC, as they are already known in sun.security.util.CurveDB. It does not introduce the twisted curves from