Thanks for the reviews on this. I see Bernd Eckenfels has suggested
removed an additional import statement the sasl/digest/NoQuoteParams
test, no problem, I will do that. He also suggested some clean-up for
the pkcs11/Provider/Login.java test. That seems reasonable too but
perhaps a bit beyon
I have no objections to removing this class. Fix looks fine. I'm ok with
adding Bernd's suggestions as well, as they are both trivial cleanups.
--Sean
On 12/10/2013 11:46 AM, Alan Bateman wrote:
DialogCallbackHandler is the sample Swing based CallbackHandler in the
JDK-specific API to JAAS. I
Alan,
in case you need to make a second revision, I would sneak in the removal
of the TextCallbackHandler import in NoQuoteParams. It seems not to be
used similiar to the DialogCallback.
Another nit, For the Login.java I would add the password to the
constructor of $PasswordCallbackHandle
DialogCallbackHandler is the sample Swing based CallbackHandler in the
JDK-specific API to JAAS. It's problematic for our modularity efforts
and as folks may recall, we deprecated it in JDK 8 with a warning to say
that it would be removed in a future release. It was also flagged in JEP
162 as
