Re: Code Review Request, JDK-8180643 Illegal handshake message

2017-08-02 Thread Xuelei Fan
On 8/2/2017 3:29 PM, Weijun Wang wrote: Looks fine. Maybe you can add a comment near the definition of these constants that when a new one is added it should be listed in the isUnsupported() method. Good suggestion! It's a concern of mine, too. Thanks, Xuelei Thanks Max On Aug 3, 2017

Re: Code Review Request, JDK-8180643 Illegal handshake message

2017-08-02 Thread Weijun Wang
Looks fine. Maybe you can add a comment near the definition of these constants that when a new one is added it should be listed in the isUnsupported() method. Thanks Max > On Aug 3, 2017, at 6:18 AM, Xuelei Fan wrote: > > Hi, > > Please review the update: > http://cr.openjdk.java.net/~xuel

Code Review Request, JDK-8180643 Illegal handshake message

2017-08-02 Thread Xuelei Fan
Hi, Please review the update: http://cr.openjdk.java.net/~xuelei/8180643/webrev.00/ This update is trying to detect unknown or unsupported handshake messages sooner rather later. Thanks, Xuelei