Re: Code review request, 8025415, Test SSLSocketImplThrowsWrongExceptions.java timed out

2013-12-24 Thread Xuelei Fan
On 12/25/2013 11:09 AM, Weijun Wang wrote: Overall it's good, but the exception dealing part can be cleaner. 230 Exception exception = null; 231 232 /* 233 * Check various exception conditions. 234 */ 235 if ((local != null) && (remote != nul

Re: Code review request, 8025415, Test SSLSocketImplThrowsWrongExceptions.java timed out

2013-12-24 Thread Weijun Wang
Overall it's good, but the exception dealing part can be cleaner. 230 Exception exception = null; 231 232 /* 233 * Check various exception conditions. 234 */ 235 if ((local != null) && (remote != null)) { 236 // If both failed, return t

Re: Code review request, 8025415, Test SSLSocketImplThrowsWrongExceptions.java timed out

2013-12-24 Thread Xuelei Fan
ping ... On 12/20/2013 4:14 PM, Xuelei Fan wrote: Hi Weijun, Another simple test stabilization fix. webrev: http://cr.openjdk.java.net/~xuelei/8025415/webrev.00/ This intermittent failure may caused by that server may also throw exception, which cannot be caught with current client-server tes

Code review request, 8025415, Test SSLSocketImplThrowsWrongExceptions.java timed out

2013-12-20 Thread Xuelei Fan
Hi Weijun, Another simple test stabilization fix. webrev: http://cr.openjdk.java.net/~xuelei/8025415/webrev.00/ This intermittent failure may caused by that server may also throw exception, which cannot be caught with current client-server test template. This fix is trying to use the new SSL