+1
--
best regards,
Anthony
On 10/17/2013 09:11 PM, alexander potochkin wrote:
Hello Leif
Looks good to me
I had a look at the PolicyTool code
and indeed it is better to leave the IO processing as is at this moment.
Thanks
alexp
Hi All,
A new webrev is available at:
http://cr.openjdk.
Hello Leif
Looks good to me
I had a look at the PolicyTool code
and indeed it is better to leave the IO processing as is at this moment.
Thanks
alexp
Hi All,
A new webrev is available at:
http://cr.openjdk.java.net/~weijun/7025699/webrev.01/
The following new changes were made:
1. Adde
Hi All,
A new webrev is available at:
http://cr.openjdk.java.net/~weijun/7025699/webrev.01/
The following new changes were made:
1. Added call to SwingUtilities.invokeLater() in main() to run the GUI
initialization on the Event Dispatch Thread.
2. Minor corrections to initial size and place
Hi Max,
I don't have expertise in this code so I haven't reviewed the fix
thoroughly. I'd like to point out one thing though: unlike AWT, Swing is
a single-threaded GUI toolkit. While in AWT you can create
components/windows and call APIs on any thread, in Swing everything
GUI-related must be
Hello
Well, performing I/O or other blocking operations on EDT can only
freeze the app's GUI for the period of blocking. If developers/users
are OK with that, this is fine with me too.
I don't think an I/O blocking operation on EDT is acceptable. It can
freeze the whole application and giv
Well, performing I/O or other blocking operations on EDT can only freeze
the app's GUI for the period of blocking. If developers/users are OK
with that, this is fine with me too.
However, you should still call all Swing APIs (including creating your
components/windows) on the EDT. And I don't
Thanks for the good feedback. We will make sure to move to move the
GUI instantiation to the EDT and the file I/O to a worker thread.
All other operations are event driven and therefore occur directly
on the EDT.
Leif
On 2013-10-15 09:56, alexander potochkin wrote:
Hello
Well, performing I/
Policy Tool is a GUI editor for the plain text policy file. The only I/O
is loading the policy file from disk and it should be quite small, so I
think there won't be a problem here.
Thanks
Max
On 10/15/13 8:08 PM, Anthony Petrov wrote:
Hi Max,
I don't have expertise in this code so I haven't
Hi All
Please review the fix at
http://cr.openjdk.java.net/~weijun/7025699/webrev.00/
The fix includes porting PolicyTool from AWT to Swing, defining
mnemonics for menu items and buttons, and adding keyboard shortcuts for
the File -> New/Open/Save items. Several tests are updated also.
T
Hi All
Please take a look at
http://cr.openjdk.java.net/~weijun/7025699/webrev.00/
The bug is about policytool not accessible through a keyboard. Mainly
two problems: First menu items have no key accelerators. Second,
pressing ENTER on any button is not working.
Basically I made these ch
10 matches
Mail list logo
