Re: Code review request: 7110803: SASL service for multiple hostnames

2012-10-30 Thread Sean Mullan
Hi Max, Looks good. A few minor comments: * SaslServerFactory 64: typo: s/to. or null/to, or null/ * Sasl 124: it would be helpful to mention the methods that the serverName argument is referring to. * GssKrb5Server.java 76: s/Will/will --Sean On 10/17/12 11:14 PM, Weijun Wang wrote: > Hi

Code review request: 7110803: SASL service for multiple hostnames

2012-10-17 Thread Weijun Wang
Hi All Please take a look at http://cr.openjdk.java.net/~weijun/7110803/webrev.00/ In Sasl.createSaslServer() method, the serverName argument is documented as "[t]he non-null fully qualified host name of the server". This means a SASL service must specify the exact hostname it is serving a