> I still need an official reviewer.
Thanks for looking into this, I was going check into it today if you
didn't. I figured it must be something in byte comparison. Sure enough.
Good catches! :) That code's been in there a long time!
Only nit is Copyright Dates if you choose to update.
R
On 5/6/2014 9:31 PM, Florian Weimer wrote:
> On 05/06/2014 02:00 PM, Xuelei Fan wrote:
>
>> Storing both int version and major/minor byte versions is a little bit
>> redundancy. The update is significant. I will focus on the signed byte
>> issue in this fix.
>
> Yes, I get that. I've verified
On 05/06/2014 03:37 PM, Xuelei Fan wrote:
On 5/6/2014 9:31 PM, Florian Weimer wrote:
On 05/06/2014 02:00 PM, Xuelei Fan wrote:
Storing both int version and major/minor byte versions is a little bit
redundancy. The update is significant. I will focus on the signed byte
issue in this fix.
Ye
On 5/6/2014 9:39 PM, Florian Weimer wrote:
> On 05/06/2014 03:37 PM, Xuelei Fan wrote:
>> On 5/6/2014 9:31 PM, Florian Weimer wrote:
>>> On 05/06/2014 02:00 PM, Xuelei Fan wrote:
>>>
Storing both int version and major/minor byte versions is a little bit
redundancy. The update is signific
On 05/06/2014 02:00 PM, Xuelei Fan wrote:
Storing both int version and major/minor byte versions is a little bit
redundancy. The update is significant. I will focus on the signed byte
issue in this fix.
Yes, I get that. I've verified that you've covered all the version
comparisons.
I was
On 5/6/2014 7:41 PM, Florian Weimer wrote:
> On 05/06/2014 12:10 PM, Xuelei Fan wrote:
>
>> Please review this simple but interesting fix:
>>http://cr.openjdk.java.net/~xuelei/8042449/webrev.00/
>
> It's strange that the code caches the major/minor version components as
> fields of ProtocolVe
On 05/06/2014 12:10 PM, Xuelei Fan wrote:
Please review this simple but interesting fix:
http://cr.openjdk.java.net/~xuelei/8042449/webrev.00/
It's strange that the code caches the major/minor version components as
fields of ProtocolVersion, but these fields cannot be used directly and
st
Hi,
Please review this simple but interesting fix:
http://cr.openjdk.java.net/~xuelei/8042449/webrev.00/
During the checking of invalid record version, a byte to byte comparing
is coded as:
if (...
recordVersion.major > ProtocolVersion.MAX.major) {
throw new SSLException
}
"r
