LGTM as well… thanks a lot!
> On 5. Nov 2018, at 20:22, Xuelei Fan wrote:
>
> It looks fine to me.
>
> Thanks,
> Xuelei
>
> On 11/5/2018 10:59 AM, Anthony Scarpino wrote:
>> Hi,
>> I'd like to get a code review of this simple change. It's a simple check to
>> make sure the hostname variable
It looks fine to me.
Thanks,
Xuelei
On 11/5/2018 10:59 AM, Anthony Scarpino wrote:
Hi,
I'd like to get a code review of this simple change. It's a simple
check to make sure the hostname variable is not null and throw a proper
exception.
http://cr.openjdk.java.net/~ascarpino/8211339/webrev
Hi,
I'd like to get a code review of this simple change. It's a simple
check to make sure the hostname variable is not null and throw a proper
exception.
http://cr.openjdk.java.net/~ascarpino/8211339/webrev.00/
Tony
Done…
Received:
We will review your report and have assigned it an internal review ID : 9057381
I used Java8 as Java version but mentioned that it also happens on 11.
Hope it helps,
Norman
> On 24. Sep 2018, at 19:19, Xuelei Fan wrote:
>
> Hi Norman,
>
> It looks like a bug to me. Would
Hi Norman,
It looks like a bug to me. Would you please file a new bug?
Thanks,
Xuelei
On 9/22/2018 3:40 PM, Norman Maurer wrote:
Hi all,
I think I found another bug in the the SSL implementation (well really
in the TrustManager related part) which leads to a NPE. I was able to
reproduce th
Hi all,
I think I found another bug in the the SSL implementation (well really in the
TrustManager related part) which leads to a NPE. I was able to reproduce this
on Java8 and Java11 (ea28) but I am sure it also exists on 9 and 10.
While trying to write some test code for netty I did somethin
