Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Andrew, Can I ask what the status of the 7044060 patch is like for jdk7u ? Is it also ready for review ? 7044060: Need to support NSA Suite B Cryptography algorithms Some argue that the benefits of the 4963723/SHA-224 fix are minor without the above bug fix also being ready. I presume there a

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Thanks for the code reviews Valerie. Andrew - looks like you need to submit new review with 7169496. Note that you still need to file for approval once code review is complete : http://openjdk.java.net/projects/jdk7u/groundrules.html I'm just being cautious on this one given the possible beha

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Changes on Tests look fine. Regards, Valerie On 1/7/2015 3:30 PM, Valerie Peng wrote: I looked through the source changes and they look fine, except that the following related fix should also be combined for completeness: 7169496: Problem with the SHA-224 support for SunMSCAPI provider webre

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

I looked through the source changes and they look fine, except that the following related fix should also be combined for completeness: 7169496: Problem with the SHA-224 support for SunMSCAPI provider webrev for 7169496: http://cr.openjdk.java.net/~valeriep/7169496/webrev.00/ As for the test

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

- Original Message - > Can you elaborate on 'this and a couple of other patches' - is that supposed > to be all of the corresponding JEP 130? Some part of it? > > Considering that the JEP 130 has legal and docs implications that imply more > work having to be done than just back porting a

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Can you elaborate on 'this and a couple of other patches' - is that supposed to be all of the corresponding JEP 130? Some part of it? Considering that the JEP 130 has legal and docs implications that imply more work having to be done than just back porting a couple of change sets, I think you

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

- Original Message - > Considering that the issue was a P3 RFE rather than a high priority bug fix, > it's not clear to me why it would be necessary to backport it into 7u80, at > the end point in the release cycle. > I don't have anything to do with the assignment of such priorities. >

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Gah, apologies, forgot about your note: Removal of change to java.security.spec.MGF1ParameterSpec to avoid introducing a new public variable. No CCC needed. -Rob On 23/12/14 16:56, Rob McKenna wrote: Actually, another kink: this requires ccc approval for a backport to 7. -Rob On

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Actually, another kink: this requires ccc approval for a backport to 7. -Rob On 23/12/14 16:52, [email protected] wrote: Considering that the issue was a P3 RFE rather than a high priority bug fix, it's not clear to me why it would be necessary to backport it into 7u80, at the end

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

Considering that the issue was a P3 RFE rather than a high priority bug fix, it's not clear to me why it would be necessary to backport it into 7u80, at the end point in the release cycle. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile

PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

- Original Message - > Valerie Peng (original author) is probably best suited to reviewing this > but I think she's out of the office the moment and back next week. Let's > hope we can get an update/review then. > Hi, Any movement on this? It's been three months. Thanks. > regards, > S