Re: Please Review Test Fix of Bug 7177045

2012-07-12 Thread Brad Wetmore
Sorry for the delay Dan. Please work with Kurchi to get this pushed. On 7/5/2012 1:38 PM, Dan Xu wrote: Hi Brad, Thanks for your good suggestions. I have fixed most of them and re-uploaded my changes at http://cr.openjdk.java.net/~dxu/7177045.01/. The reason that I chose ArrayDeque instead o

Re: Please Review Test Fix of Bug 7177045

2012-07-05 Thread Dan Xu
Hi Brad, Thanks for your good suggestions. I have fixed most of them and re-uploaded my changes at http://cr.openjdk.java.net/~dxu/7177045.01/. The reason that I chose ArrayDeque instead of LinkedList is that ArrayDequeseems have better performance. According to the java doc, "most ArrayDequ

Re: Please Review Test Fix of Bug 7177045

2012-06-28 Thread Brad Wetmore
Dan, congrats on assembling and posting your first webrev. Besides the big picture things, since you are new, I'll also be looking for minor things that you may or may not know yet. On 6/28/2012 1:49 PM, Dan Xu wrote: Security code reviewers, I have fixed a security test failure and posted m

Please Review Test Fix of Bug 7177045

2012-06-28 Thread Dan Xu
Security code reviewers, I have fixed a security test failure and posted my changes at http://cr.openjdk.java.net/~dxu/7177045/. Please help review it. Thanks! -Dan