Re: RFC: OpenJDK JarSigner API

2015-08-14 Thread Mandy Chung
> On Aug 14, 2015, at 7:18 PM, Weijun Wang wrote: > > > > On 8/15/2015 5:37 AM, Mandy Chung wrote: >> Looks good in general. >> >> Have you considered using “Algorithm” instead of “Alg” the abbreviation in >> the method names digesting, sigAlg etc >> > > I reuse the jarsigner option names

Re: RFC: OpenJDK JarSigner API

2015-08-14 Thread Weijun Wang
On 8/15/2015 5:37 AM, Mandy Chung wrote: Looks good in general. Have you considered using “Algorithm” instead of “Alg” the abbreviation in the method names digesting, sigAlg etc I reuse the jarsigner option names (-sigalg, -digestalg, -tsa), hoping people are already familiar with them.

Re: RFC: OpenJDK JarSigner API

2015-08-14 Thread Mandy Chung
Looks good in general. Have you considered using “Algorithm” instead of “Alg” the abbreviation in the method names digesting, sigAlg etc The Builder::build method: After a {@code JarSigner} object is built, calling any setter method on this {@code Builder} will have no effect on it. Wil

Re: RFC: OpenJDK JarSigner API

2015-08-14 Thread Sean Mullan
This looks good to me. --Sean On 08/08/2015 09:56 AM, Weijun Wang wrote: Hi All JDK 9 is more restricted on calling sun.* public methods but we know there are users calling sun.security.tools.jarsigner.Main to sign jar files. A new API is proposed for this very purpose in OpenJDK. Please note

RFC: OpenJDK JarSigner API

2015-08-08 Thread Weijun Wang
Hi All JDK 9 is more restricted on calling sun.* public methods but we know there are users calling sun.security.tools.jarsigner.Main to sign jar files. A new API is proposed for this very purpose in OpenJDK. Please note it is defined in a jdk.* package therefore not a Java SE API. We are als