Thanks for the review Brad. Yes - I'll make those changes before pushing.
regards,
Sean.
On 23/02/2018 20:14, Brad Wetmore wrote:
Minor comments. I'm ok with leaving as is, but this seems cleaner.
MyProvider.java
---
Would prefer to use the non-deprecated super call.
Minor comments. I'm ok with leaving as is, but this seems cleaner.
MyProvider.java
---
Would prefer to use the non-deprecated super call.
*Digest.java
Would you consider making these 3 duplicate classes into a single class,
with the three public derived classes
Looks fine to me.
Thanks,
Valerie
On 2/15/2018 1:04 AM, Seán Coffey wrote:
A reminder for this review..
regards,
Sean.
On 09/02/2018 16:25, Seán Coffey wrote:
Looking to push a new test which helps test CloneableDigest code.
It's something that arose during JDK-8193683 fix.
The test was
Looks fine to me. Thanks!
Xuelei
On 2/15/2018 1:04 AM, Seán Coffey wrote:
A reminder for this review..
regards,
Sean.
On 09/02/2018 16:25, Seán Coffey wrote:
Looking to push a new test which helps test CloneableDigest code. It's
something that arose during JDK-8193683 fix.
The test was
A reminder for this review..
regards,
Sean.
On 09/02/2018 16:25, Seán Coffey wrote:
Looking to push a new test which helps test CloneableDigest code. It's
something that arose during JDK-8193683 fix.
The test was contributed by Brad Wetmore. I've converted it to use the
SSLSocketTemplate.
Looking to push a new test which helps test CloneableDigest code. It's
something that arose during JDK-8193683 fix.
The test was contributed by Brad Wetmore. I've converted it to use the
SSLSocketTemplate.
JBS : https://bugs.openjdk.java.net/browse/JDK-8193892
webrev :
