Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v5]

2022-06-09 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with two additional commits since the last revision: - 8209935: Test to cover CodeSource.getCodeSigners() - 8209935: Test to cover CodeSource.getCodeSigners() - Changes: - a

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sibabrata Sahoo
On Thu, 9 Jun 2022 21:12:26 GMT, Sean Mullan wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8209935: Test to cover CodeSource.getCodeSigners() > > test/jdk/java/security/CodeSource/CertsMatch.java line 27: > >

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sean Mullan
On Wed, 8 Jun 2022 10:30:45 GMT, Sibabrata Sahoo wrote: >> A Test updated to cover the getCodeSigners. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > 8209935: Test to cover CodeSource.getCodeSigners() Marked as reviewe

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-08 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: 8209935: Test to cover CodeSource.getCodeSigners() - Changes: - all: https://git.openjdk.java.net/jdk/pull/8286/files -

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v3]

2022-06-08 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last re

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v2]

2022-04-26 Thread Sean Mullan
On Mon, 18 Apr 2022 13:26:30 GMT, Sibabrata Sahoo wrote: >> A Test updated to cover the getCodeSigners. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update Implies.java Marked as reviewed by mullan (Reviewer). -

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v2]

2022-04-18 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update Implies.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/8286/files - new: https://git.openjdk.java.

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v2]

2022-04-18 Thread Sibabrata Sahoo
On Mon, 18 Apr 2022 13:22:35 GMT, Sibabrata Sahoo wrote: >> A Test updated to cover the getCodeSigners. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update Implies.java All comments addressed. - PR: htt

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners()

2022-04-18 Thread Sean Mullan
On Mon, 18 Apr 2022 09:46:06 GMT, Sibabrata Sahoo wrote: > A Test updated to cover the getCodeSigners. test/jdk/java/security/CodeSource/Implies.java line 60: > 58: = new CodeSource(thatURL, > (java.security.cert.Certificate[]) null); > 59: if (thisCs.implies(thatCs) !=

RFR: 8209935: Test to cover CodeSource.getCodeSigners()

2022-04-18 Thread Sibabrata Sahoo
A Test updated to cover the getCodeSigners. - Commit messages: - Update Implies.java - 8209935: Test to cover CodeSource.getCodeSigners() Changes: https://git.openjdk.java.net/jdk/pull/8286/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8286&range=00 Issue: https://