Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-06 Thread Nico Williams
On Mon, Dec 03, 2018 at 05:10:26PM +, Seán Coffey wrote: > I made further edits to update the DNSName comment code to reference RFC > 5280 rather than the obsoleted RFC 2459. I also updated the test case with a > few extra tests per suggestion from Chris and others. Moved the dataprovider > int

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-05 Thread Chris Hegarty
On Dec 4, 2018, at 1:11 AM, Seán Coffey wrote: whoops: latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v4/webrev/ Regards, Sean. Looks good. -Chris.

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-05 Thread Weijun Wang
The change looks fine to me. Thanks Max > On Dec 4, 2018, at 1:11 AM, Seán Coffey wrote: > > whoops: > latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v4/webrev/ > Regards, > Sean.

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-03 Thread Seán Coffey
started to use lately. e.g. https://bugs.openjdk.java.net/browse/JDK-8207768 regards, Sean. Gruss Bernd -- http://bernd.eckenfels.net Von: Seán Coffey Gesendet: Freitag, November 16, 2018 5:15 PM An: Bernd Eckenfels; [email protected] Betreff: Re: RFR: 8213952: Relax DNSName restr

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-03 Thread Seán Coffey
should be followed up in separate enhancement. We could lean on the new `jdk.includeInExceptions` Security property which other component areas have started to use lately. e.g. https://bugs.openjdk.java.net/browse/JDK-8207768 regards, Sean. Gruss Bernd -- http://bernd.eckenfels.net Von: Seán Co

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-28 Thread Sean Mullan
parate enhancement. We could lean on the new `jdk.includeInExceptions` Security property which other component areas have started to use lately. e.g. https://bugs.openjdk.java.net/browse/JDK-8207768 regards, Sean. Gruss Bernd -- http://bernd.eckenfels.net Von: Seán Coffey Gesendet: Freitag, Nov

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-27 Thread Seán Coffey
e and SAN), would be good if all of them have the same keyword? I cleaned up some other references to DNSName in the sun.security.x509 package. I'm not sure what classes you were referencing the above examples from. new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v2/webrev

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-26 Thread Weijun Wang
, 80, 92. >>>>> webrev updated in place : >>>>> http://cr.openjdk.java.net/~coffeys/webrev.8213952.v2/webrev/ >>>>> >>>>> >>>>>> me applies to SAN or NameConstrained context and the validation logic >>>>

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-25 Thread Weijun Wang
e validation logic >>>>> does not know — so it’s not only more unified but also less missleading) >>>>> >>>>> BTW: probably not inthe scope of this fix but a subtype for validation >>>>> errors which have getters for context/location and ma

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-23 Thread Seán Coffey
nExceptions` Security property which other component areas have started to use lately. e.g. https://bugs.openjdk.java.net/browse/JDK-8207768 regards, Sean. Gruss Bernd -- http://bernd.eckenfels.net Von: Seán Coffey Gesendet: Freitag, November 16, 2018 5:15 PM An: Bernd Eckenfels; security

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-22 Thread Weijun Wang
s without >>> relying on the message or Stacktraces. >> >> That's a nice idea and one that should be followed up in separate >> enhancement. We could lean on the new `jdk.includeInExceptions` Security >> property which other component areas have started to use lately. &

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-21 Thread Seán Coffey
*Von:* Seán Coffey *Gesendet:* Freitag, November 16, 2018 5:15 PM *An:* Bernd Eckenfels; [email protected] *Betreff:* Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123 Thanks for the comments Bernd. comments inline.. On 16/11/18 12:40, Bernd

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-21 Thread Seán Coffey
DK-8207768 regards, Sean. Gruss Bernd -- http://bernd.eckenfels.net *Von:* Seán Coffey *Gesendet:* Freitag, November 16, 2018 5:15 PM *An:* Bernd Eckenfels; [email protected] *Betreff:* Re: RFR: 8213952: Relax DNSNam

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-16 Thread Bernd Eckenfels
nicer validation reports without relying on the message or Stacktraces. Gruss Bernd -- http://bernd.eckenfels.net Von: Seán Coffey Gesendet: Freitag, November 16, 2018 5:15 PM An: Bernd Eckenfels; [email protected] Betreff: Re: RFR: 8213952: Relax DNSName

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-16 Thread Seán Coffey
13952: Relax DNSName restriction as per RFC 1123 Looking to make an adjustment to DNSName constructor to help comply with RFC 1123 https://bugs.openjdk.java.net/browse/JDK-8213952 http://cr.openjdk.java.net/~coffeys/webrev.8213952/webrev/ regards, Sean.

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-16 Thread Bernd Eckenfels
://bernd.eckenfels.net Von: security-dev im Auftrag von Seán Coffey Gesendet: Freitag, November 16, 2018 12:25 PM An: OpenJDK Dev list Betreff: RFR: 8213952: Relax DNSName restriction as per RFC 1123 Looking to make an adjustment to DNSName constructor to help comply with

RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-16 Thread Seán Coffey
Looking to make an adjustment to DNSName constructor to help comply with RFC 1123 https://bugs.openjdk.java.net/browse/JDK-8213952 http://cr.openjdk.java.net/~coffeys/webrev.8213952/webrev/ regards, Sean.