Hi Sean,
I think the changes look good including the proposed tweaks to the message
suggested by Alan.
Best
Lance
> On Jul 2, 2020, at 4:10 AM, Seán Coffey wrote:
>
> Thanks for the review Alan. I'm in contact with Max already about possible
> follow up enhancements in this area. It would be
Thanks for the review Alan. I'm in contact with Max already about
possible follow up enhancements in this area. It would be worked via a
follow on JBS record.
Regarding the error message, I'm fine with your suggestion. We can go
with this then:
"POSIX file permission attributes detected. These
On 30/06/2020 14:51, Seán Coffey wrote:
:
During the CSR review, a suggestion was made to have jarsigner
preserve such attributes by default. Warnings about these attributes
will also be added during signing and verify operations (if detected).
Yes, signing should be additive so the origina
Thanks for the review Max. All edits made bar the
"Event.clearReportListener(Event.ReporterCategory.POSIXPERMS);"
suggested edit. That's already in a finally block.
latest webrev:
https://cr.openjdk.java.net/~coffeys/webrev.8218021.v5/webrev/
I plan to push once I have a clean test run.
reg
-
src/java.base/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java
@@ -248,7 +248,7 @@ private static X509CRL getCRL(URIName name) throws
CertStoreException {
debug.println("Trying to fetch CRL from DP " + uri);
}
Event.repor
Thanks Lance.
During the CSR review, a suggestion was made to have jarsigner preserve
such attributes by default. Warnings about these attributes will also be
added during signing and verify operations (if detected).
webrev: https://cr.openjdk.java.net/~coffeys/webrev.8218021.v4/webrev/
rega
