> Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING
> variant and related code that is no longer needed in the PKIX implementation.
Sean Mullan has updated the pull request incrementally with one additional
commit since the last revision:
Remove NPE check in Validator.get
On Thu, 29 Jul 2021 15:09:14 GMT, Weijun Wang wrote:
> Looks good. One nit: `Validator::getInstance` methods are internal. Does it
> really matter to check for null?
Good point. Also, NPE will be thrown later when an `EndEntityChecker` is
invoked and it needs to determine the variant to use. H
On Thu, 29 Jul 2021 14:24:52 GMT, Sean Mullan wrote:
> Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING
> variant and related code that is no longer needed in the PKIX implementation.
Looks good. One nit: `Validator::getInstance` methods are internal. Does it
really matte
Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING variant
and related code that is no longer needed in the PKIX implementation.
-
Commit messages:
- 8232066: Remove outdated code/methods from PKIX implementation
Changes: https://git.openjdk.java.net/jdk/pull/49
