Re: [8u] RFR: 8233223: Add Amazon Root CA certificates

2019-12-21 Thread Volker Simonis
On Thu, Dec 19, 2019 at 11:09 AM Severin Gehwolf wrote: > > Hi Volker, > > On Wed, 2019-12-18 at 22:27 +0100, Volker Simonis wrote: > > Hi Severin, > > > > not strictly a 8u "Reviewer" yet, but I've looked at your changes > > (this one and 8232019) nevertheless :) > > Thanks for the review! > > >

Re: [8u] RFR: 8233223: Add Amazon Root CA certificates

2019-12-20 Thread Martin Balao
I'm not a reviewer but I've had a look at Severin's 8233223 backport and looked good to me too (4 / 4 certificates verified).

RE: [8u] RFR: 8233223: Add Amazon Root CA certificates

2019-12-19 Thread Langer, Christoph
; security-dev d...@openjdk.java.net> > Subject: Re: [8u] RFR: 8233223: Add Amazon Root CA certificates > > Hi Volker, > > On Wed, 2019-12-18 at 22:27 +0100, Volker Simonis wrote: > > Hi Severin, > > > > not strictly a 8u "Reviewer" yet, but I've looked a

Re: [8u] RFR: 8233223: Add Amazon Root CA certificates

2019-12-19 Thread Severin Gehwolf
Hi Volker, On Wed, 2019-12-18 at 22:27 +0100, Volker Simonis wrote: > Hi Severin, > > not strictly a 8u "Reviewer" yet, but I've looked at your changes > (this one and 8232019) nevertheless :) Thanks for the review! > They both look good, except that I can not verify the new "cacert" > file bec

Re: [8u] RFR: 8233223: Add Amazon Root CA certificates

2019-12-18 Thread Volker Simonis
Hi Severin, not strictly a 8u "Reviewer" yet, but I've looked at your changes (this one and 8232019) nevertheless :) They both look good, except that I can not verify the new "cacert" file because it is not in the patch (because it is binary). Not sure if it is necessary to upload the whole file

[8u] RFR: 8233223: Add Amazon Root CA certificates

2019-12-17 Thread Severin Gehwolf
Hi, Could I please get a review of this OpenJDK 8u backport of 8233223 which depends on 8u backport of 8232019[1]. The JDK 11u patch did not apply cleanly for a couple of reasons: 1. 8u still has the binary blob for cacerts (JDK-8193255 not backported, yet). Instead, I've updated to the

Re: RFR: 8233223: Add Amazon Root CA certificates

2019-11-27 Thread Sean Mullan
Looks good. --Sean On 11/26/19 2:07 PM, Rajan Halade wrote: May I request you to review this fix to add 4 new Amazon root certificates to cacerts. Webrev: http://cr.openjdk.java.net/~rhalade/8233223/webrev.00/ Thanks, Rajan

RFR: 8233223: Add Amazon Root CA certificates

2019-11-26 Thread Rajan Halade
May I request you to review this fix to add 4 new Amazon root certificates to cacerts. Webrev: http://cr.openjdk.java.net/~rhalade/8233223/webrev.00/ Thanks, Rajan