Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-28 Thread Anthony Scarpino
On Wed, 28 Oct 2020 10:52:27 GMT, Magnus Ihse Bursie wrote: >> throw new IllegalStateException( >> new InvalidAlgorithmParameterException( >> "Curve not supported: Private: " + >> ((privNC != null) ? privNC.toString() : " unknown") +

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-28 Thread Magnus Ihse Bursie
On Tue, 22 Sep 2020 14:04:55 GMT, Sean Mullan wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove JDKOPT_DETECT_INTREE_EC from configure.ac > > throw new IllegalStateException( > new

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-26 Thread Magnus Ihse Bursie
Sorry for being late on this one (I'm working through a huge backlog), but it does not seem like the removal was complete. ENABLE_INTREE_EC is still present in spec.gmk. And it is still checked in modules/jdk.crypto.ec/Lib.gmk. In fact, this entire file should be removed. Anthony, can you

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Anthony Scarpino
On Thu, 24 Sep 2020 21:37:14 GMT, Weijun Wang wrote: >> jdk.disabled.namedCurves is commented out and I don't think it's good for >> every operation disabled algorithms call to >> check an empty property. The description for the disabledAlgorithm >> properties say you have to use "include",

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Weijun Wang
On Thu, 24 Sep 2020 21:15:34 GMT, Anthony Scarpino wrote: >> src/java.base/share/conf/security/java.security line 636: >> >>> 634: # >>> 635: jdk.certpath.disabledAlgorithms=MD2, MD5, SHA1 jdkCA & usage >>> TLSServer, \ >>> 636: RSA keySize < 1024, DSA keySize < 1024, EC keySize < 224 >>

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Anthony Scarpino
On Thu, 24 Sep 2020 19:48:45 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change exception for ec keyagreement >> fix supportedcurves in SunEC > >

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Weijun Wang
On Wed, 23 Sep 2020 23:38:03 GMT, Anthony Scarpino wrote: >> This change removes the native elliptic curves library code; as well as, and >> calls to that code, tests, and files >> associated with those libraries. The makefiles have been changed to remove >> from all source builds of the ec

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-23 Thread Anthony Scarpino
> This change removes the native elliptic curves library code; as well as, and > calls to that code, tests, and files > associated with those libraries. The makefiles have been changed to remove > from all source builds of the ec code. The > SunEC system property is removed and java.security

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-23 Thread Anthony Scarpino
On Wed, 23 Sep 2020 17:07:21 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove JDKOPT_DETECT_INTREE_EC from configure.ac > > src/jdk.crypto.ec/share/classes/sun/security/ec/SunEC.java

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-23 Thread Anthony Scarpino
On Tue, 22 Sep 2020 13:53:12 GMT, Sean Mullan wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove JDKOPT_DETECT_INTREE_EC from configure.ac > >

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-23 Thread Valerie Peng
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino wrote: >> This change removes the native elliptic curves library code; as well as, and >> calls to that code, tests, and files >> associated with those libraries. The makefiles have been changed to remove >> from all source builds of the ec

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-22 Thread Sean Mullan
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino wrote: >> This change removes the native elliptic curves library code; as well as, and >> calls to that code, tests, and files >> associated with those libraries. The makefiles have been changed to remove >> from all source builds of the ec

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-22 Thread Erik Joelsson
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino wrote: >> This change removes the native elliptic curves library code; as well as, and >> calls to that code, tests, and files >> associated with those libraries. The makefiles have been changed to remove >> from all source builds of the ec

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-21 Thread Xue-Lei Andrew Fan
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino wrote: >> This change removes the native elliptic curves library code; as well as, and >> calls to that code, tests, and files >> associated with those libraries. The makefiles have been changed to remove >> from all source builds of the ec

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-21 Thread Anthony Scarpino
On Mon, 21 Sep 2020 23:50:07 GMT, Erik Joelsson wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove JDKOPT_DETECT_INTREE_EC from configure.ac > > make/autoconf/jdk-options.m4 line 234: > >> 232: # Enable

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-21 Thread Anthony Scarpino
> This change removes the native elliptic curves library code; as well as, and > calls to that code, tests, and files > associated with those libraries. The makefiles have been changed to remove > from all source builds of the ec code. The > SunEC system property is removed and java.security

Re: RFR: 8235710: Remove the legacy elliptic curves

2020-09-21 Thread Erik Joelsson
On Mon, 21 Sep 2020 21:10:58 GMT, Anthony Scarpino wrote: > This change removes the native elliptic curves library code; as well as, and > calls to that code, tests, and files > associated with those libraries. The makefiles have been changed to remove > from all source builds of the ec

RFR: 8235710: Remove the legacy elliptic curves

2020-09-21 Thread Anthony Scarpino
This change removes the native elliptic curves library code; as well as, and calls to that code, tests, and files associated with those libraries. The makefiles have been changed to remove from all source builds of the ec code. The SunEC system property is removed and java.security