Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Bradford Wetmore
On Thu, 11 Mar 2021 14:53:22 GMT, Roger Riggs wrote: >> Disable the "missing" target for java.smartcardio from doclint. > > Please assign a new bug and title to ignore/suppress the warnings. > The original issue 8252833 should be left open. > Thanks Closing, as it's unclear which approach shou

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Roger Riggs
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Please assign a new bug and title to ignore/suppress the warnings. The original issue 8252833 should be left open. Thanks - Changes requested by rriggs (Rev

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Magnus Ihse Bursie
On Thu, 11 Mar 2021 09:25:34 GMT, Magnus Ihse Bursie wrote: >> Disable the "missing" target for java.smartcardio from doclint. > > Looks good to me. ... however, this fix does not achieve what the bug report is asking for. The patch here will modify flags to javac. The JBS issue talks about fla

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Magnus Ihse Bursie
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Revoking approval. - Changes requested by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2930

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Magnus Ihse Bursie
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Looks good to me. - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2930

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Iris Clark
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2930

RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Bradford Wetmore
Disable the "missing" target for java.smartcardio from doclint. - Commit messages: - Forgot copyright date update - 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module Changes: https://git.openjdk.java.net/jdk/pull/2930/files Webrev: https://webrevs.ope