Re: RFR: 8256363: Define toString() for MGF1ParameterSpec [v3]

2020-11-18 Thread Sean Mullan
On Tue, 17 Nov 2020 15:37:18 GMT, Weijun Wang wrote: >> Without this method, `PSSParameterSpec::toString` shows something like: >> MD: SHA-256 >> MGF: java.security.spec.MGF1ParameterSpec@77b52d12 >> SaltLength: 32 >> TrailerField: 1 >> This is ugly. >> >> Noreg-trivial. > > Weijun Wang has upda

Re: RFR: 8256363: Define toString() for MGF1ParameterSpec [v3]

2020-11-17 Thread Weijun Wang
On Tue, 17 Nov 2020 19:36:31 GMT, Sean Mullan wrote: >> New commit and the output will look like: >> PSSParameterSpec[hashAlgorithm=SHA-256, >> maskGenAlgorithm=MGF1ParameterSpec[hashAlgorithm=SHA-256], saltLength=32, >> trailerField=1] >> I'm using the ASN.1 field names here. (Precisely the na

Re: RFR: 8256363: Define toString() for MGF1ParameterSpec [v3]

2020-11-17 Thread Sean Mullan
On Tue, 17 Nov 2020 15:34:37 GMT, Weijun Wang wrote: > New commit and the output will look like: > > ``` > PSSParameterSpec[hashAlgorithm=SHA-256, > maskGenAlgorithm=MGF1ParameterSpec[hashAlgorithm=SHA-256], saltLength=32, > trailerField=1] > ``` > > I'm using the ASN.1 field names here. (Pre

Re: RFR: 8256363: Define toString() for MGF1ParameterSpec [v3]

2020-11-17 Thread Weijun Wang
On Mon, 16 Nov 2020 16:30:04 GMT, Sean Mullan wrote: >> minor comment on spacing for MGF1 toString() > >> Do you want me to consolidate `PSSParameterSpec::toString` into one line? >> Multi-line toString is usually not very friendly to debug output (esp for >> grep). > > Good question. Readabil

Re: RFR: 8256363: Define toString() for MGF1ParameterSpec [v3]

2020-11-17 Thread Weijun Wang
> Without this method, `PSSParameterSpec::toString` shows something like: > MD: SHA-256 > MGF: java.security.spec.MGF1ParameterSpec@77b52d12 > SaltLength: 32 > TrailerField: 1 > This is ugly. > > Noreg-trivial. Weijun Wang has updated the pull request incrementally with one additional commit sin