Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-12 Thread Hai-May Chao
On Fri, 12 Feb 2021 14:49:17 GMT, Weijun Wang wrote: >> Changed as suggested. > > Sorry, I should have been more verbose on my suggestion. I was thinking about > passing in **_only_** the `KeyIdentifier` and _**not**_ `akey`. After all > both of them are for the same purpose and it's clear to

Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-12 Thread Weijun Wang
On Thu, 11 Feb 2021 22:10:55 GMT, Hai-May Chao wrote: >> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1482: >> >>> 1480: byte[] signerSubjectKeyIdExt = >>> ((X509Certificate)signerCert).getExtensionValue( >>> 1481:

Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-11 Thread Hai-May Chao
On Thu, 11 Feb 2021 19:48:23 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> API used to get AKID > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1482: > >> 1480:

Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-11 Thread Weijun Wang
On Thu, 11 Feb 2021 01:01:56 GMT, Hai-May Chao wrote: >> This change is made for compliance with RFC 5280 section 4.2.1.1 for >> Authority Key Identifier extension. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > API used

Re: RFR: 8257497: Key identifier compliance issue [v3]

2021-02-10 Thread Hai-May Chao
> This change is made for compliance with RFC 5280 section 4.2.1.1 for > Authority Key Identifier extension. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: API used to get AKID - Changes: - all: