Re: RFR: 8258736: No break in the loop [v2]

2020-12-21 Thread Xue-Lei Andrew Fan
On Mon, 21 Dec 2020 18:37:46 GMT, Bradford Wetmore wrote: > Approved with the condition of updating the copyright year. > Good catch! > There was also a failure in the Linux Presubmit tests which is probably bogus. > I checked the failure, which is not related to this update. > Looks good oth

Re: RFR: 8258736: No break in the loop [v2]

2020-12-21 Thread Xue-Lei Andrew Fan
> It looks like the break is missed in the loop of the > SSLCipher.createReadCipher() and createWriteCipher() methods. See the change > set. > > Code cleanup, no new regression test. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8258736 Xue-Lei Andrew Fan has updated the pull request incr

Re: RFR: 8258736: No break in the loop

2020-12-21 Thread Bradford Wetmore
On Sat, 19 Dec 2020 05:48:53 GMT, Xue-Lei Andrew Fan wrote: > It looks like the break is missed in the loop of the > SSLCipher.createReadCipher() and createWriteCipher() methods. See the change > set. > > Code cleanup, no new regression test. > > Bug: https://bugs.openjdk.java.net/browse/JDK

RFR: 8258736: No break in the loop

2020-12-18 Thread Xue-Lei Andrew Fan
It looks like the break is missed in the loop of the SSLCipher.createReadCipher() and createWriteCipher() methods. See the change set. Code cleanup, no new regression test. Bug: https://bugs.openjdk.java.net/browse/JDK-8258736 - Commit messages: - 8258736: No break in the loop