> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 12 commits:
- Merge branch 'master' into 8258915
- Merge
On Mon, 22 Feb 2021 07:12:57 GMT, Valerie Peng wrote:
> Changes look good. Thanks~
Thanks a lot for your patience and precious feedback.
-
PR: https://git.openjdk.java.net/jdk/pull/2070
On Fri, 19 Feb 2021 22:21:06 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> sim
On Thu, 18 Feb 2021 19:18:26 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
>> line 261:
>>
>>> 259: md5.update(clientRandom);
>>> 260: md5.update(serverRandom);
>>> 261: dig
On Thu, 18 Feb 2021 11:09:17 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> materials
>
> Other files look fine. Thanks~
Add one more clean. Adjusting macKeyLen and ivLen in
TlsKeyMaterialParame
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
simpler spec creation, and one more clean
-
Changes:
-
On Thu, 18 Feb 2021 11:08:06 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> materials
>
> src/java.base/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
> line 261:
>
>> 259:
On Thu, 18 Feb 2021 05:03:58 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> materials
>
> src/java.base/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
> line 97:
>
>> 95:
On Sat, 6 Feb 2021 14:40:04 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> mate
On Sat, 6 Feb 2021 14:40:04 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> mate
On Sat, 6 Feb 2021 14:40:04 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> mate
On Sat, 6 Feb 2021 14:40:04 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> mate
On Fri, 5 Feb 2021 16:34:29 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> drbg
>>
>> only in patch2:
>> unchanged:
>
> src/java.base/share/classes/sun/security/provider/CtrDrbg.java line 5
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
materials
-
Changes:
- all: https://git.openjdk.java.ne
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
TLS key generators
-
Changes:
- all: https://git.openjd
On Fri, 29 Jan 2021 18:40:02 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> drb
On Thu, 4 Feb 2021 15:20:02 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanups for key generations
>
> src/java.base/share/classes/com/sun/crypto/provider/AESCrypt.java line 690:
>
>> 688:
On Thu, 4 Feb 2021 16:13:11 GMT, Valerie Peng wrote:
> > New commit for key generations.
>
> How about the Tls*Generator classes in SunJCE provider? Looks like they need
> to be handled as well.
I'll take a look. I thought the secrets going in and out of them are ephemeral.
-
PR:
On Thu, 4 Feb 2021 15:25:14 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanups for key generations
>
> src/java.base/share/classes/com/sun/crypto/provider/DESedeKeyGenerator.java
> line 2:
>
On Thu, 28 Jan 2021 16:13:01 GMT, Weijun Wang wrote:
>
>
> New commit for key generations.
How about the Tls*Generator classes in SunJCE provider? Looks like they need to
be handled as well.
-
PR: https://git.openjdk.java.net/jdk/pull/2070
On Thu, 28 Jan 2021 16:12:58 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> cle
On Thu, 28 Jan 2021 16:12:58 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> cle
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
drbg
only in patch2:
unchanged:
-
Changes:
- all
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
cleanups for key generations
-
Changes:
- all: https://
On Fri, 22 Jan 2021 21:25:25 GMT, Weijun Wang wrote:
>> New commit. However, I was writing test to detect leak in
>> `RSAPrivateKeySpec` conversion and add more key->spec->key for other
>> algorithms and find more leaks. Will fix in another commit.
>
> Another new commit. Last time I only fixed
On Sat, 23 Jan 2021 16:04:53 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 221:
>>
>>> 219: if (encodedKey == null) {
>>> 220: try {
>>> 221: DerOutputStream tmp = new DerOutputStream();
>>
>> What is the criteria
On Sat, 23 Jan 2021 16:32:16 GMT, Weijun Wang wrote:
>> I'll take a look. The test does not show it. Maybe because of the reversing?
>
> I found out the reason. This method is called during key pair generation but
> my test only deals with manually crafted keys (so that I know what special
> by
On Sat, 23 Jan 2021 16:11:02 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line
>> 116:
>>
>>> 114: encode();
>>> 115: } catch (IOException e) {
>>> 116: throw new ProviderException("Cannot produce ASN.1
>>> enc
On Sat, 23 Jan 2021 16:12:43 GMT, Weijun Wang wrote:
>> src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java line
>> 133:
>>
>>> 131: out.putInteger(1); // version 1
>>> 132: out.putOctetString(sOctets);
>>> 133: Arrays.fill(sOctets, (byte)0)
On Sat, 23 Jan 2021 05:09:46 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> keyfactory operations on own keyspec
>
> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line
> 1
On Sat, 23 Jan 2021 03:59:12 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more wrap, less copy
>
> src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 221:
>
>> 219: if (en
On Fri, 22 Jan 2021 21:28:53 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> key
On Fri, 22 Jan 2021 21:28:53 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> key
On Fri, 22 Jan 2021 15:43:05 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> mor
On Fri, 22 Jan 2021 15:39:53 GMT, Weijun Wang wrote:
>> Just pushed a new commit. First I merged into the RSA PKCS #1 code change
>> from @valeriepeng, and then reapplied the cleanup to `RSAKeyFactory`. Most
>> new code change is inside `RSAPrivateCrtKeyImpl`. I also updated `DerValue`
>> and
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
keyfactory operations on own keyspec
-
Changes:
- all:
On Thu, 21 Jan 2021 16:25:13 GMT, Weijun Wang wrote:
>>> please add noreg label to the JBS bug.
>>
>> Added. Thanks.
>
> Just pushed a new commit. First I merged into the RSA PKCS #1 code change
> from @valeriepeng, and then reapplied the cleanup to `RSAKeyFactory`. Most
> new code change is i
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
more wrap, less copy
-
Changes:
- all: https://git.open
On Fri, 22 Jan 2021 08:18:15 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - rsa
>> - Merge
>> - 8258915: More temporary buffer cleanup
>>
>>8258915: More t
On Fri, 22 Jan 2021 14:35:46 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/PrivateKeyInfo.java line
>> 98:
>>
>>> 96:
>>> 97: public void clear() {
>>> 98: Arrays.fill(privkey, (byte)0);
>>
>> check for null just in case?
>
> `val.data.getOctetStri
On Fri, 22 Jan 2021 07:44:41 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - rsa
>> - Merge
>> - 8258915: More temporary buffer cleanup
>>
>>8258915: More t
On Fri, 22 Jan 2021 07:18:22 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - rsa
>> - Merge
>> - 8258915: More temporary buffer cleanup
>>
>>8258915: More t
On Thu, 21 Jan 2021 16:23:21 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Thu, 21 Jan 2021 16:23:21 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Thu, 21 Jan 2021 16:23:21 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Thu, 21 Jan 2021 16:23:21 GMT, Weijun Wang wrote:
>> Clean up temporary byte array, char array, and keyspec around keys and
>> passwords.
>>
>> No new regression test.
>
> Weijun Wang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Thu, 14 Jan 2021 02:52:08 GMT, Weijun Wang wrote:
>> please add noreg label to the JBS bug.
>
>> please add noreg label to the JBS bug.
>
> Added. Thanks.
Just pushed a new commit. First I merged into the RSA PKCS #1 code change from
@valeriepeng, and then reapplied the cleanup to `RSAKeyFa
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- rsa
- Merge
- 8258915: More temporary
On Wed, 13 Jan 2021 22:19:00 GMT, Rajan Halade wrote:
> please add noreg label to the JBS bug.
Added. Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/2070
On Wed, 13 Jan 2021 21:32:07 GMT, Weijun Wang wrote:
> Clean up temporary byte array, char array, and keyspec around keys and
> passwords.
>
> No new regression test.
please add noreg label to the JBS bug.
-
PR: https://git.openjdk.java.net/jdk/pull/2070
Clean up temporary byte array, char array, and keyspec around keys and
passwords.
No new regression test.
-
Commit messages:
- 8258915: More temporary buffer cleanup
Changes: https://git.openjdk.java.net/jdk/pull/2070/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=20
51 matches
Mail list logo
