Re: RFR: 8259223: Simplify boolean expression in the SunJSSE provider [v2]

2021-01-05 Thread Xue-Lei Andrew Fan
> There are some boolean expressions that could be improved for better > readability in the SunJSSE provider implementation. For example: > > - if (cert instanceof X509Certificate == false) { > + if (!(cert instanceof X509Certificate)) { > > - return isDTLS ? true : (id >= TLS10.id); > + retu

Re: RFR: 8259223: Simplify boolean expression in the SunJSSE provider

2021-01-05 Thread Sean Mullan
On Tue, 5 Jan 2021 07:06:42 GMT, Xue-Lei Andrew Fan wrote: > There are some boolean expressions that could be improved for better > readability in the SunJSSE provider implementation. For example: > > - if (cert instanceof X509Certificate == false) { > + if (!(cert instanceof X509Certificate)

RFR: 8259223: Simplify boolean expression in the SunJSSE provider

2021-01-04 Thread Xue-Lei Andrew Fan
There are some boolean expressions that could be improved for better readability in the SunJSSE provider implementation. For example: - if (cert instanceof X509Certificate == false) { + if (!(cert instanceof X509Certificate)) { - return isDTLS ? true : (id >= TLS10.id); + return isDTLS || (id