Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-29 Thread Clive Verghese
On Thu, 28 Jan 2021 19:04:29 GMT, Xue-Lei Andrew Fan wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. > > src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1702: > >> 1700: if

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-28 Thread Xue-Lei Andrew Fan
On Tue, 26 Jan 2021 18:56:57 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Clive Verghese
On Wed, 27 Jan 2021 17:46:03 GMT, Xue-Lei Andrew Fan wrote: >> Changes requested by rhalade (Reviewer). > > For the CSR request, I updated the component to security-libs/javax.net.ssl, > add 17 as one of the fix versions, and added myself as reviewer. Thank you. I will change the status of the

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Xue-Lei Andrew Fan
On Wed, 13 Jan 2021 18:46:10 GMT, Rajan Halade wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Update copyright year >> - Add error handling guidelines >> - Fix bugids and use

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-26 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request with a new target base due to a merge or