Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

2021-03-26 Thread Claes Redestad
On Fri, 26 Mar 2021 14:39:47 GMT, Roger Riggs wrote: >> A number of HexFormat methods converting from strings to numbers do not use >> delimiter, prefix, suffix, and uppercase parameters and would be more >> convenient if the methods were static. >> >> These APIs were added early in JDK 17

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

2021-03-26 Thread Roger Riggs
> A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and are being updated before GA. > This PR updates existing

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-26 Thread Chris Hegarty
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote: > A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-25 Thread Claes Redestad
On Thu, 25 Mar 2021 21:50:46 GMT, Roger Riggs wrote: >> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 4582: >> >>> 4580: int pos = 0; >>> 4581: for (char c: value.toCharArray()) { >>> 4582:

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-25 Thread Naoto Sato
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote: > A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-25 Thread Roger Riggs
On Thu, 25 Mar 2021 21:05:47 GMT, Claes Redestad wrote: >> A number of HexFormat methods converting from strings to numbers do not use >> delimiter, prefix, suffix, and uppercase parameters and would be more >> convenient if the methods were static. >> >> These APIs were added early in JDK

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-25 Thread Claes Redestad
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote: > A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and

RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-25 Thread Roger Riggs
A number of HexFormat methods converting from strings to numbers do not use delimiter, prefix, suffix, and uppercase parameters and would be more convenient if the methods were static. These APIs were added early in JDK 17 and are being updated before GA. This PR updates existing uses in the