Re: RFR: 8265426: Update java.security to use instanceof pattern variable [v5]

2021-05-07 Thread Roger Riggs
On Thu, 6 May 2021 14:42:20 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the >> `java.security` package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull

Re: RFR: 8265426: Update java.security to use instanceof pattern variable [v5]

2021-05-07 Thread Patrick Concannon
On Mon, 26 Apr 2021 17:52:05 GMT, Jesper Steen Møller wrote: > Changes look good, except for the unneeded parenthesis? > > (but I'm not a committer, so it's less useful) Hi Jesper, thanks for your suggestions and well spotted. I've addressed the issues and responded to your comments with the

Re: RFR: 8265426: Update java.security to use instanceof pattern variable [v5]

2021-05-06 Thread Weijun Wang
On Thu, 6 May 2021 14:42:20 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the >> `java.security` package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull

Re: RFR: 8265426: Update java.security to use instanceof pattern variable [v5]

2021-05-06 Thread Daniel Fuchs
On Thu, 6 May 2021 14:42:20 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the >> `java.security` package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull

Re: RFR: 8265426: Update java.security to use instanceof pattern variable [v5]

2021-05-06 Thread Patrick Concannon
On Tue, 27 Apr 2021 04:38:32 GMT, Punikekk wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8265426: changed order of equals check; refactored Identity.equals method > >

Re: RFR: 8265426: Update java.security to use instanceof pattern variable [v5]

2021-05-06 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: