On Tue, 19 Oct 2021 13:10:15 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment in test
>
> Approved the PR. Thanks. I have a small comment on the CSR.
@wangweij Updated the CSR with
> It'd be useful to have a -version option for keytool and jarsigner. Many
> other JDK tools already have a -version option. This is to add -version
> option to keytool and jarsigner like jar command does.
>
> CSR review:
> https://bugs.openjdk.java.net/browse/JDK-8275174
Hai-May Chao has
On Tue, 19 Oct 2021 13:10:15 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment in test
>
> Approved the PR. Thanks. I have a small comment on the CSR.
@wangweij Thanks for reviewing
On Tue, 19 Oct 2021 06:26:17 GMT, Hai-May Chao wrote:
>> It'd be useful to have a -version option for keytool and jarsigner. Many
>> other JDK tools already have a -version option. This is to add -version
>> option to keytool and jarsigner like jar command does.
>>
>> CSR review:
>>
On Tue, 19 Oct 2021 06:26:17 GMT, Hai-May Chao wrote:
>> It'd be useful to have a -version option for keytool and jarsigner. Many
>> other JDK tools already have a -version option. This is to add -version
>> option to keytool and jarsigner like jar command does.
>>
>> CSR review:
>>
> It'd be useful to have a -version option for keytool and jarsigner. Many
> other JDK tools already have a -version option. This is to add -version
> option to keytool and jarsigner like jar command does.
>
> CSR review:
> https://bugs.openjdk.java.net/browse/JDK-8275174
Hai-May Chao has
> It'd be useful to have a -version option for keytool and jarsigner. Many
> other JDK tools already have a -version option. This is to add -version
> option to keytool and jarsigner like jar command does.
>
> CSR review:
> https://bugs.openjdk.java.net/browse/JDK-8275174
Hai-May Chao has
On Tue, 19 Oct 2021 03:40:55 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix -version in jarsigner and update tests
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java
On Tue, 19 Oct 2021 01:09:26 GMT, Hai-May Chao wrote:
>> It'd be useful to have a -version option for keytool and jarsigner. Many
>> other JDK tools already have a -version option. This is to add -version
>> option to keytool and jarsigner like jar command does.
>>
>> CSR review:
>>
On Fri, 15 Oct 2021 13:49:27 GMT, Weijun Wang wrote:
>> It'd be useful to have a -version option for keytool and jarsigner. Many
>> other JDK tools already have a -version option. This is to add -version
>> option to keytool and jarsigner like jar command does.
>>
>> CSR review:
>>
> It'd be useful to have a -version option for keytool and jarsigner. Many
> other JDK tools already have a -version option. This is to add -version
> option to keytool and jarsigner like jar command does.
>
> CSR review:
> https://bugs.openjdk.java.net/browse/JDK-8275174
Hai-May Chao has
On Fri, 15 Oct 2021 13:34:48 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix -version in jarsigner and update tests
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java
On Thu, 14 Oct 2021 16:04:08 GMT, Hai-May Chao wrote:
> It'd be useful to have a -version option for keytool and jarsigner. Many
> other JDK tools already have a -version option. This is to add -version
> option to keytool and jarsigner like jar command does.
>
> CSR review:
>
On Thu, 14 Oct 2021 16:04:08 GMT, Hai-May Chao wrote:
> It'd be useful to have a -version option for keytool and jarsigner. Many
> other JDK tools already have a -version option. This is to add -version
> option to keytool and jarsigner like jar command does.
>
> CSR review:
>
It'd be useful to have a -version option for keytool and jarsigner. Many other
JDK tools already have a -version option. This is to add -version option to
keytool and jarsigner like jar command does.
-
Commit messages:
- 8272163: Add -version option to keytool and jarsigner
15 matches
Mail list logo